Skip to main content

max / makeover-webview

28.3 KB · 729 lines History Blame Raw
1 //! Column layout and row structure for lists and tables.
2 //!
3 //! The other half of phase B. [`form`](crate::form) renders a field; this
4 //! renders the frame a list of rows sits in: which columns exist, how wide they
5 //! are, which ones survive a narrow viewport, and the cell containers a row is
6 //! made of.
7 //!
8 //! # What this does not do
9 //!
10 //! It does not render a cell's contents. That is the crate's own limit, stated
11 //! in `makeover_layout`'s "Where the description stops": generate the boring
12 //! 80% so the bespoke 20% gets the attention. A goingson task row carries
13 //! delegated action hooks with argument substitution, four nested sub-renderers,
14 //! conditional state classes and aria labels built from data. A description
15 //! expressive enough to emit that is a templating language wearing a
16 //! description's name.
17 //!
18 //! So the split is the one [`Markup`] already draws for forms: this owns the
19 //! structure and the app owns what goes in it. What that removes from an app is
20 //! not small — cell order, cell classes, the grid tracks, and above all the
21 //! narrowing rules, which is where addressing columns by position goes wrong.
22 //!
23 //! # Why positions are the bug
24 //!
25 //! goingson hides its mobile columns with `nth-child(n+5)` against a
26 //! seven-column table, plus a separate `nth-child(3)`, plus two class-based
27 //! rules — the same fact said three ways, two of them positional. Insert a
28 //! column anywhere left of the cut and the wrong one disappears, silently,
29 //! because nothing in the stylesheet knows what column five *is*.
30 //! [`Priority`] is the fix: a renderer narrows by raising a cutoff, and never
31 //! by counting.
32
33 use crate::form::Markup;
34 use crate::{Emit, push_class};
35 use makeover_layout::{CellPart, Column, Priority, RowPart, Width};
36 use std::fmt::Write as _;
37
38 /// The lengths the description deferred.
39 ///
40 /// [`Width`] says `Content`, `Fixed` or `Fill` and deliberately carries no
41 /// magnitude, because a magnitude is a CSS answer and the description is read
42 /// by renderers that have no pixels. So the numbers arrive here instead, the
43 /// way a field's value arrives in [`Filling`](crate::form::Filling) rather than
44 /// in `Field`.
45 ///
46 /// Looked up by column name, because an app's columns are not all one size:
47 /// goingson's task table has six distinct fixed widths.
48 #[derive(Debug, Clone, Copy, Default)]
49 pub struct Sizing<'a> {
50 /// `(column name, CSS length)`. The length is the track for a
51 /// [`Width::Fixed`] column and the floor for a [`Width::Fill`] one.
52 pub lengths: &'a [(&'a str, &'a str)],
53 /// Used for a column with no entry above. Empty means `auto`.
54 pub fallback: &'a str,
55 }
56
57 impl Sizing<'_> {
58 /// The length for a named column.
59 fn length_for(&self, name: &str) -> &str {
60 self.lengths
61 .iter()
62 .find(|(column, _)| *column == name)
63 .map_or_else(
64 || {
65 if self.fallback.is_empty() {
66 "auto"
67 } else {
68 self.fallback
69 }
70 },
71 |(_, length)| *length,
72 )
73 }
74
75 /// The grid track for one column.
76 fn track(&self, column: &Column<'_>) -> String {
77 match column.width {
78 Width::Content => "max-content".to_owned(),
79 Width::Fixed => self.length_for(column.name).to_owned(),
80 Width::Fill => format!("minmax({}, 1fr)", self.length_for(column.name)),
81 // A width added to the description since this renderer was built.
82 // `auto` is the track that makes no claim, which is the honest
83 // answer to a claim this renderer cannot read.
84 _ => "auto".to_owned(),
85 }
86 }
87 }
88
89 /// The class a cell of this column carries.
90 ///
91 /// Derived from the column's own name, which is what makes the narrowing rules
92 /// addressable. `data-column` would do as well; a class is what both webview
93 /// apps already key their cell styling on.
94 ///
95 /// The name is reduced to identifier characters first. See [`push_column_name`].
96 #[must_use]
97 pub fn column_class(column: &Column<'_>, opts: &Emit) -> String {
98 let mut out = String::new();
99 push_column_class(&mut out, column, opts);
100 out
101 }
102
103 /// The class a cell of this column carries, written into a buffer the caller
104 /// already has.
105 ///
106 /// [`column_class`]'s streaming form. It is the one that runs per cell per row,
107 /// and it used to allocate twice to get there: once for `col-<name>` and once
108 /// for the prefix in front of it.
109 pub fn push_column_class(out: &mut String, column: &Column<'_>, opts: &Emit) {
110 out.push_str(opts.class_prefix);
111 out.push_str("col-");
112 push_column_name(out, column.name);
113 }
114
115 /// A column's name as the identifier half of its class.
116 ///
117 /// # Why this is not escaping
118 ///
119 /// The name is the one app-supplied string this crate puts in a class attribute
120 /// rather than in text or an `aria-label`, and until 0.41.0 it went in raw. A
121 /// column named `a" onclick="steal()` emitted
122 ///
123 /// ```html
124 /// <div class="cell col-a" onclick="steal() cell-fill cell-keeps">
125 /// ```
126 ///
127 /// which is a live event handler on every cell of that column. HTML escaping is
128 /// the reflex and it is the wrong tool here, because a class is read twice: once
129 /// by the HTML parser, which would decode `&quot;` back to a quote, and once by
130 /// a CSS selector, which [`narrowing_css`] writes from this same function. An
131 /// escaped name is safe in the attribute and unmatchable from the stylesheet,
132 /// so the two halves of the narrowing would stop meeting -- silently, the way
133 /// every other defect this module's comments record did.
134 ///
135 /// Reducing the name to identifier characters answers both. What comes out is a
136 /// valid CSS identifier, so the selector matches, and it holds none of the five
137 /// characters an attribute value can be ended with, so there is nothing to
138 /// escape.
139 ///
140 /// # What it changes for a name that was already fine
141 ///
142 /// Nothing. Alphanumerics, `_` and `-` pass through, and every column name in
143 /// the tree is made of those. A name that is *not* was already broken rather
144 /// than merely unsafe: `Due date` emitted `col-Due date`, which the HTML parser
145 /// reads as the two classes `col-Due` and `date`, and which `narrowing_css`
146 /// wrote as a descendant selector that matched neither. Both now agree on
147 /// `col-Due-date`.
148 ///
149 /// Alphanumeric in the Unicode sense, not the ASCII one. CSS identifiers admit
150 /// everything from U+00A0 up, so a column named `Größe` keeps its name; folding
151 /// it to `Gr--e` would collide with a neighbouring column for nothing.
152 pub fn push_column_name(out: &mut String, name: &str) {
153 for ch in name.chars() {
154 // Substituted rather than dropped. Two columns called `a b` and `ab`
155 // are different columns, and dropping would give them one class and one
156 // set of narrowing rules between them.
157 if ch.is_alphanumeric() || ch == '_' || ch == '-' {
158 out.push(ch);
159 } else {
160 out.push('-');
161 }
162 }
163 }
164
165 /// The class saying how wide a cell of this column asks to be.
166 ///
167 /// A bounded vocabulary, unlike [`column_class`], which is why the stylesheet
168 /// can carry the rule. [`Width`] is `#[non_exhaustive]`, and a member added
169 /// upstream lands on the fill class: a column that takes the slack is the
170 /// behaviour that makes no claim, matching the `auto` track
171 /// [`Sizing::track`] falls back to for the same reason.
172 fn width_class(width: Width) -> &'static str {
173 match width {
174 Width::Content => "cell-content",
175 Width::Fixed => "cell-fixed",
176 _ => "cell-fill",
177 }
178 }
179
180 /// The class saying when a cell of this column drops.
181 ///
182 /// [`Priority`] said as a class rather than as a cutoff, so the hiding can live
183 /// in the stylesheet instead of being generated per table. That is what a
184 /// [`display: table`](crate::table_rules) frame needs and a grid one cannot use:
185 /// a grid also has to shorten its track list, which only the columns themselves
186 /// can say.
187 fn drop_class(priority: Priority) -> &'static str {
188 match priority {
189 Priority::Optional => "cell-drops-first",
190 Priority::Secondary => "cell-drops-next",
191 // A priority added upstream keeps its column. `Priority` is
192 // `#[non_exhaustive]`, and of the two ways to be wrong about one this
193 // renderer has not learned, showing a column that should have dropped
194 // is the one the user can see and work around.
195 _ => "cell-keeps",
196 }
197 }
198
199 /// Every class a cell of this column carries.
200 ///
201 /// The column's own name, how wide it asks to be, and when it drops. A header
202 /// cell has to carry the same three or the header and the body disagree about
203 /// which column just disappeared, and a renderer emitting its own header row
204 /// should call this rather than assemble the list a second time.
205 #[must_use]
206 pub fn column_classes(column: &Column<'_>, opts: &Emit) -> String {
207 let mut out = String::new();
208 push_column_classes(&mut out, column, opts);
209 out
210 }
211
212 /// Every class a cell of this column carries, written into a buffer the caller
213 /// already has.
214 ///
215 /// [`column_classes`]'s streaming form, and four allocations fewer per cell: the
216 /// three names and the string joining them.
217 pub fn push_column_classes(out: &mut String, column: &Column<'_>, opts: &Emit) {
218 push_column_class(out, column, opts);
219 out.push(' ');
220 push_class(out, width_class(column.width), opts);
221 out.push(' ');
222 push_class(out, drop_class(column.priority), opts);
223 }
224
225 /// The `grid-template-columns` value for the columns kept at `cutoff`.
226 ///
227 /// Emitting only the surviving tracks is what keeps the track list and the
228 /// hiding in agreement. An app that hides a cell with `display: none` but
229 /// leaves its track in place gets a column of empty space, which is the other
230 /// half of goingson's mobile bug: its narrow rule drops to four tracks by hand
231 /// and has to be edited in step with the `nth-child` cut.
232 #[must_use]
233 pub fn grid_template_columns(
234 columns: &[Column<'_>],
235 sizing: &Sizing<'_>,
236 cutoff: Priority,
237 ) -> String {
238 columns
239 .iter()
240 .filter(|column| column.kept_at(cutoff))
241 .map(|column| sizing.track(column))
242 .collect::<Vec<_>>()
243 .join(" ")
244 }
245
246 /// The rules that narrow `selector` to the columns kept at `cutoff`.
247 ///
248 /// Both halves together: the shortened track list, and `display: none` on each
249 /// dropped column *by its own class*. Nothing counts positions, so inserting a
250 /// column changes what is emitted rather than changing which column vanishes.
251 ///
252 /// `selector` may be a selector list. A descendant is appended to each part
253 /// rather than to the whole, because appending to the whole changes what the
254 /// earlier parts match: `.head, .row > .col-x` reads as "`.head`, or a `.col-x`
255 /// inside `.row`", so `.head` itself would be hidden.
256 #[must_use]
257 pub fn narrowing_css(
258 columns: &[Column<'_>],
259 selector: &str,
260 sizing: &Sizing<'_>,
261 cutoff: Priority,
262 opts: &Emit,
263 ) -> String {
264 let parts: Vec<&str> = selector.split(',').map(str::trim).collect();
265
266 let mut css = format!(
267 "{} {{\n grid-template-columns: {};\n}}\n",
268 parts.join(", "),
269 grid_template_columns(columns, sizing, cutoff)
270 );
271
272 for column in columns.iter().filter(|c| !c.kept_at(cutoff)) {
273 let class = column_class(column, opts);
274 let targets: Vec<String> = parts
275 .iter()
276 .map(|part| format!("{part} > .{class}"))
277 .collect();
278 let _ = write!(css, "{} {{\n display: none;\n}}\n", targets.join(",\n"));
279 }
280 css
281 }
282
283 /// One cell of a row.
284 ///
285 /// The contents are [`Markup`] rather than text, and that is the whole shape of
286 /// this module: a cell holds whatever the app builds, and the app says so by
287 /// naming it. Escaping a cell here would be wrong as well as impossible — a
288 /// task row's description cell is five nested spans and a badge.
289 #[derive(Debug, Clone, Copy)]
290 pub struct Cell<'a> {
291 /// Which column this fills, by name.
292 pub column: &'a str,
293 /// What the cell holds, when the whole cell is one thing.
294 ///
295 /// Carries the cell-part class the stylesheet half emits, so a cell that is
296 /// nothing but controls says so in the description's own words rather than
297 /// in the app's.
298 ///
299 /// This was `Option<RowPart>` until 0.25.0, which was the drift
300 /// `makeover-layout` 0.14.0 named: a table cell borrowing the list row's
301 /// vocabulary, because the table side had none. A row's parts answer a
302 /// different question (which of six emphases this run of text takes) from a
303 /// cell's (whether this is text, tokens, controls or a link).
304 ///
305 /// `None` for a cell mixing parts. A cell holding a value *and* a strip of
306 /// tokens *and* a control is three parts in one container, and each one
307 /// wears its own class inside — this field is for the single-part case,
308 /// where a wrapper span would say nothing the cell has not already said.
309 pub part: Option<CellPart>,
310 /// The contents. Trusted app markup.
311 pub content: Markup<'a>,
312 }
313
314 impl<'a> Cell<'a> {
315 /// A cell with no cell part.
316 #[must_use]
317 pub const fn new(column: &'a str, content: Markup<'a>) -> Self {
318 Self {
319 column,
320 part: None,
321 content,
322 }
323 }
324 }
325
326 /// The class for a row part.
327 ///
328 /// This comment used to say `RowPart` was the one closed enum left here, and
329 /// that gaining a member would stop this compiling — "the same lockstep break
330 /// `non_exhaustive` was added elsewhere to end". makeover-layout 0.9.0 ended
331 /// it: the enum gained [`RowPart::Tokens`] and `#[non_exhaustive]` in the same
332 /// release, so the prediction was paid off rather than waited for.
333 ///
334 /// The fallback is what that costs. A member added upstream lands here as a
335 /// bare `row-part` with no rule of its own, which is a thing rendering plainly
336 /// rather than a build that stops. Grep this function when adopting a new
337 /// makeover-layout.
338 ///
339 /// Public since 0.27.0. A row's parts are emitted by whoever builds the row
340 /// element, and that is not always this crate: `cells_html` emits a table's
341 /// cells, but a list row carries the app's identity and hooks, so a screen
342 /// renderer writes it. quasi-webview wrote this list out a second time to do
343 /// that, which made the obligation in the paragraph above land on a function
344 /// its author would not think to grep.
345 /// Every class [`part_class`] can return, including the fallback.
346 ///
347 /// Beside the match rather than derived from it, because a `match` over a
348 /// `#[non_exhaustive]` enum cannot be enumerated from outside. It carries the
349 /// same obligation the match does and a test below holds the two together, so
350 /// a new arm added without a new entry fails rather than silently narrowing
351 /// what a checker believes this crate can emit.
352 pub const ROW_PART_CLASSES: &[&str] = &[
353 "row-primary",
354 "row-secondary",
355 "row-meta",
356 "row-actions",
357 "row-tokens",
358 "row-proportion",
359 "row-part",
360 ];
361
362 /// Every class [`cell_part_class`] can return, including the fallback.
363 ///
364 /// See [`ROW_PART_CLASSES`] for why it is written out.
365 pub const CELL_PART_CLASSES: &[&str] = &[
366 "cell-value",
367 "cell-tokens",
368 "cell-actions",
369 "cell-link",
370 "cell-part",
371 ];
372
373 #[must_use]
374 pub fn part_class(part: RowPart) -> &'static str {
375 match part {
376 RowPart::Primary => "row-primary",
377 RowPart::Secondary => "row-secondary",
378 RowPart::Meta => "row-meta",
379 RowPart::Actions => "row-actions",
380 RowPart::Tokens => "row-tokens",
381 RowPart::Proportion => "row-proportion",
382 _ => "row-part",
383 }
384 }
385
386 /// The class for a cell part.
387 ///
388 /// [`part_class`]'s table half, added with `makeover-layout` 0.14.0's
389 /// [`CellPart`]. The fallback is there for the same reason and costs the same
390 /// thing: a member added upstream lands as a bare `cell-part` with no rule of
391 /// its own, rather than as a build that stops. Grep this function too when
392 /// adopting a new makeover-layout, and public since 0.27.0 for the reason
393 /// [`part_class`] is.
394 #[must_use]
395 pub fn cell_part_class(part: CellPart) -> &'static str {
396 match part {
397 CellPart::Value => "cell-value",
398 CellPart::Tokens => "cell-tokens",
399 CellPart::Actions => "cell-actions",
400 CellPart::Link => "cell-link",
401 _ => "cell-part",
402 }
403 }
404
405 /// A row's cells, in column order.
406 ///
407 /// Ordered by the columns and not by the cells, so a row cannot silently
408 /// disagree with its table about what comes where. A column with no cell gets
409 /// an empty container, which keeps the grid aligned; a cell naming no column is
410 /// dropped, because there is nowhere to put it.
411 ///
412 /// Emits the cells alone, not the row element. The row carries the app's
413 /// identity and hooks — `data-id`, a context-menu binding, a tabindex, its
414 /// state classes — and none of that is describable here.
415 ///
416 /// # Not for a webview's scroll path
417 ///
418 /// This has no consumer in either webview app, deliberately, and wiring one in
419 /// would be a mistake worth naming. goingson renders rows through a virtual
420 /// scroller whose `_render` calls its row builder **synchronously** while
421 /// scrolling; the code's own comment says scroll events fire at 60Hz+ and that
422 /// this is the hot path. Reaching Rust from there means an IPC round trip and
423 /// an `await` in that loop, per visible range, during a drag.
424 ///
425 /// So this is for the hosts where rendering already happens in Rust: an axum
426 /// route, and the router when it lands. There the objection does not apply,
427 /// because nothing crosses a process boundary to reach it. A webview app should
428 /// take [`narrowing_css`] and [`column_class`] and keep building its own rows.
429 #[must_use]
430 pub fn cells_html(columns: &[Column<'_>], cells: &[Cell<'_>], opts: &Emit) -> String {
431 let mut html = String::new();
432 cells_html_into(columns, cells, opts, &mut html);
433 html
434 }
435
436 /// A row's cells, written into a buffer the caller already has.
437 ///
438 /// [`cells_html`]'s streaming form, byte-identical to it, and the one a host
439 /// rendering a table should call: a row is emitted once per row per render, so
440 /// this is where a `String` per cell class is paid for most often.
441 pub fn cells_html_into(columns: &[Column<'_>], cells: &[Cell<'_>], opts: &Emit, out: &mut String) {
442 for column in columns {
443 let found = cells.iter().find(|cell| cell.column == column.name);
444 out.push_str("<div class=\"");
445 push_class(out, "cell", opts);
446 out.push(' ');
447 push_column_classes(out, column, opts);
448 if let Some(part) = found.and_then(|cell| cell.part) {
449 out.push(' ');
450 push_class(out, cell_part_class(part), opts);
451 }
452 out.push_str("\">");
453 out.push_str(found.map_or("", |cell| cell.content.0));
454 out.push_str("</div>");
455 }
456 }
457
458 #[cfg(test)]
459 mod tests {
460 use super::*;
461
462 #[test]
463 fn a_column_name_cannot_break_out_of_the_class_attribute() {
464 // Until 0.41.0 the name went in raw, so this emitted
465 // `class="cell col-a" onclick="steal() cell-fill ...">` -- a live
466 // handler on every cell of the column. The name is the one
467 // app-supplied string this crate puts in a class rather than in text.
468 let name = "a\" onclick=\"steal()";
469 let columns = vec![Column::new(name)];
470 let cells = vec![Cell {
471 column: name,
472 part: None,
473 content: Markup("x"),
474 }];
475 let html = cells_html(&columns, &cells, &Emit::default());
476
477 assert!(!html.contains("onclick=\"steal()"), "{html}");
478 assert!(html.contains("col-a--onclick--steal--"), "{html}");
479 // Two quotes in the whole cell, both this crate's: the ones opening and
480 // closing the class attribute. A third would be the name ending it.
481 assert_eq!(html.matches('"').count(), 2, "{html}");
482 }
483
484 #[test]
485 fn the_class_and_the_selector_that_hides_it_agree_on_the_name() {
486 // The reason the fix is a filter and not an escape. A class is read by
487 // the HTML parser and again by a CSS selector; an escaped name would be
488 // safe in the attribute and unmatchable from the stylesheet, so the
489 // narrowing would stop hiding the column it names.
490 let columns = vec![Column {
491 priority: Priority::Optional,
492 ..Column::new("Due date")
493 }];
494 let cells = vec![Cell {
495 column: "Due date",
496 part: None,
497 content: Markup("x"),
498 }];
499 let opts = Emit::default();
500
501 let html = cells_html(&columns, &cells, &opts);
502 let css = narrowing_css(&columns, ".row", &sizing(), Priority::Essential, &opts);
503
504 // One class, not the two `col-Due date` parsed as.
505 assert!(html.contains("class=\"cell col-Due-date "), "{html}");
506 assert!(css.contains(".row > .col-Due-date {"), "{css}");
507 }
508
509 #[test]
510 fn a_name_already_made_of_identifier_characters_is_untouched() {
511 // Every column name in the tree is one of these, which is what makes
512 // 0.41.0 a fix rather than a rename.
513 for name in ["description", "due", "progress", "Name", "col_2", "a-b"] {
514 let mut out = String::new();
515 push_column_name(&mut out, name);
516 assert_eq!(out, name);
517 }
518 }
519
520 #[test]
521 fn a_name_outside_ascii_keeps_itself() {
522 // CSS identifiers admit everything from U+00A0 up, so folding these to
523 // dashes would collide two columns for nothing.
524 let mut out = String::new();
525 push_column_name(&mut out, "Größe");
526 assert_eq!(out, "Größe");
527 }
528
529 fn columns() -> Vec<Column<'static>> {
530 vec![
531 Column {
532 width: Width::Fill,
533 priority: Priority::Essential,
534 ..Column::new("description")
535 },
536 Column {
537 width: Width::Fixed,
538 priority: Priority::Secondary,
539 ..Column::new("due")
540 },
541 Column {
542 width: Width::Fixed,
543 priority: Priority::Optional,
544 ..Column::new("progress")
545 },
546 ]
547 }
548
549 fn sizing() -> Sizing<'static> {
550 Sizing {
551 lengths: &[
552 ("description", "200px"),
553 ("due", "110px"),
554 ("progress", "100px"),
555 ],
556 fallback: "",
557 }
558 }
559
560 #[test]
561 fn a_fill_column_gets_a_floor_and_the_slack() {
562 let tracks = grid_template_columns(&columns(), &sizing(), Priority::Optional);
563 assert_eq!(tracks, "minmax(200px, 1fr) 110px 100px");
564 }
565
566 #[test]
567 fn a_column_with_no_length_makes_no_claim() {
568 let sizing = Sizing::default();
569 let tracks = grid_template_columns(&columns(), &sizing, Priority::Optional);
570 assert_eq!(tracks, "minmax(auto, 1fr) auto auto");
571 }
572
573 /// The point of the module. Raising the cutoff drops columns by what they
574 /// are worth, and the track list shortens to match, so the two cannot
575 /// disagree the way a hand-written `nth-child` cut and a hand-written
576 /// track list can.
577 #[test]
578 fn raising_the_cutoff_drops_columns_and_their_tracks_together() {
579 let columns = columns();
580
581 let wide = grid_template_columns(&columns, &sizing(), Priority::Optional);
582 assert_eq!(wide.split(' ').count(), 4); // minmax(200px, + 1fr) + 2
583
584 let narrow = grid_template_columns(&columns, &sizing(), Priority::Secondary);
585 assert_eq!(narrow, "minmax(200px, 1fr) 110px");
586
587 let narrowest = grid_template_columns(&columns, &sizing(), Priority::Essential);
588 assert_eq!(narrowest, "minmax(200px, 1fr)");
589 }
590
591 #[test]
592 fn narrowing_hides_a_dropped_column_by_its_own_class_not_its_position() {
593 let css = narrowing_css(
594 &columns(),
595 ".ui-mode-mobile .task-row",
596 &sizing(),
597 Priority::Secondary,
598 &Emit::default(),
599 );
600 assert!(
601 css.contains("grid-template-columns: minmax(200px, 1fr) 110px;"),
602 "{css}"
603 );
604 assert!(
605 css.contains(".ui-mode-mobile .task-row > .col-progress {"),
606 "{css}"
607 );
608 assert!(!css.contains("nth-child"), "{css}");
609 // The kept columns are not mentioned as hidden.
610 assert!(!css.contains(".col-due {\n display: none"), "{css}");
611 }
612
613 /// A selector list has to distribute, or the earlier parts of it get the
614 /// child combinator appended to the whole and start matching things they
615 /// never named. This hid an entire table header the first time it ran.
616 #[test]
617 fn a_selector_list_distributes_the_hidden_column() {
618 let css = narrowing_css(
619 &columns(),
620 ".task-header-row, .task-row",
621 &sizing(),
622 Priority::Secondary,
623 &Emit::default(),
624 );
625 assert!(
626 css.contains(".task-header-row > .col-progress,\n.task-row > .col-progress {"),
627 "{css}"
628 );
629 // The bare header selector must never appear as a hiding target.
630 assert!(
631 !css.contains(".task-header-row {\n display: none"),
632 "{css}"
633 );
634 assert!(
635 css.contains(".task-header-row, .task-row {\n grid-template-columns:"),
636 "{css}"
637 );
638 }
639
640 #[test]
641 fn cells_follow_the_columns_and_carry_their_column_class() {
642 let cells = [
643 Cell {
644 column: "due",
645 part: Some(CellPart::Value),
646 content: Markup("tomorrow"),
647 },
648 Cell::new("description", Markup("<span>Ship it</span>")),
649 ];
650 let html = cells_html(&columns(), &cells, &Emit::default());
651
652 // Column order, not cell order: description was passed second.
653 let description = html.find("Ship it").expect("description cell");
654 let due = html.find("tomorrow").expect("due cell");
655 assert!(description < due, "{html}");
656
657 // Three classes, not one: the column's own name, how wide it asks to
658 // be, and when it drops. The last two are what lets the stylesheet
659 // carry rules a described table cannot generate per table.
660 assert!(
661 html.contains(r#"<div class="cell col-description cell-fill cell-keeps">"#),
662 "{html}"
663 );
664 assert!(
665 html.contains(r#"<div class="cell col-due cell-fixed cell-drops-next cell-value">"#),
666 "{html}"
667 );
668 // progress had no cell, so it is present and empty rather than absent,
669 // or the grid would shift left by one.
670 assert!(
671 html.contains(r#"<div class="cell col-progress cell-fixed cell-drops-first"></div>"#),
672 "{html}"
673 );
674 }
675
676 /// A row is emitted once per row per render, so the streaming form is the
677 /// one a host should call and the two have to agree byte for byte.
678 #[test]
679 fn streamed_cells_are_the_cells_the_other_form_returns() {
680 let opts = Emit {
681 class_prefix: "mk-",
682 ..Emit::default()
683 };
684 let cells = [
685 Cell {
686 column: "due",
687 part: Some(CellPart::Value),
688 content: Markup("tomorrow"),
689 },
690 Cell::new("description", Markup("<span>Ship it</span>")),
691 ];
692 for cells in [&cells[..], &[]] {
693 let mut streamed = String::new();
694 cells_html_into(&columns(), cells, &opts, &mut streamed);
695 assert_eq!(streamed, cells_html(&columns(), cells, &opts));
696 }
697 for column in &columns() {
698 let mut streamed = String::new();
699 push_column_classes(&mut streamed, column, &opts);
700 assert_eq!(streamed, column_classes(column, &opts));
701 }
702 }
703
704 #[test]
705 fn a_cell_naming_no_column_is_dropped() {
706 let cells = [Cell::new("nonexistent", Markup("nowhere"))];
707 let html = cells_html(&columns(), &cells, &Emit::default());
708 assert!(!html.contains("nowhere"), "{html}");
709 }
710
711 #[test]
712 fn the_class_prefix_reaches_the_cells_and_the_narrowing() {
713 let opts = Emit {
714 class_prefix: "mk-",
715 ..Emit::default()
716 };
717 let cells = [Cell::new("due", Markup("x"))];
718 assert!(
719 cells_html(&columns(), &cells, &opts).contains("mk-cell mk-col-due"),
720 "prefix missing"
721 );
722 assert!(
723 narrowing_css(&columns(), ".t", &sizing(), Priority::Secondary, &opts)
724 .contains(".mk-col-progress"),
725 "prefix missing"
726 );
727 }
728 }
729