Skip to main content

max / makeover-immediate

Format the table module, and drop a knob that promised a choice cargo fmt --all --check is a Bento preflight gate and this had not been run through it, so build 130 failed before it reached the publish. TableStyle::sticky_header went with it. Nothing read the field, and nothing could: a TableBuilder header is sticky and there is no version that is not, so the knob offered a choice this renderer cannot make.
Author: Max Johnson <me@maxj.phd> · 2026-08-11 20:15 UTC
Signed with PGP, not checked
Commit: e72d0a469891f49b5967a0af039b8e148ba0169c
Parent: 5ceffdd
1 file changed, +7 insertions, -8 deletions
M src/table.rs +7 -8
@@ -56,11 +56,7 @@
56 56 /// this when adopting a new `makeover-layout`; `makeover-tui` carries the same
57 57 /// list for the same reason, and the two have to agree or a description narrows
58 58 /// differently in a window than in a terminal.
59 - const CUTOFFS: [Priority; 3] = [
60 - Priority::Optional,
61 - Priority::Secondary,
62 - Priority::Essential,
63 - ];
59 + const CUTOFFS: [Priority; 3] = [Priority::Optional, Priority::Secondary, Priority::Essential];
64 60
65 61 /// The lengths the description deferred, in points.
66 62 ///
@@ -111,9 +107,13 @@
111 107 /// egui_extras' own striping, off by default: the description has no word
112 108 /// for it, and a renderer that turned it on would be adding a claim the
113 109 /// other two cannot make.
110 + ///
111 + /// The only knob here that is not a metric, and it is the only one because
112 + /// egui_extras already answers the rest. A sticky heading, for one: it is
113 + /// what `TableBuilder::header` does and there is no version that does not,
114 + /// so a field offering the choice would be offering one this renderer cannot
115 + /// make.
114 116 pub striped: bool,
115 - /// Whether the heading stays put while the body scrolls.
116 - pub sticky_header: bool,
117 117 }
118 118
119 119 impl Default for TableStyle {
@@ -126,7 +126,6 @@
126 126 ascending: " \u{25B2}",
127 127 descending: " \u{25BC}",
128 128 striped: false,
129 - sticky_header: true,
130 129 }
131 130 }
132 131 }