max / makenotwork

135.9 KB · 1193 lines History Blame Raw

1	# Ultra Fuzz Report — MNW Server (Run #9 — launch eve)
2
3	Run date: 2026-05-31 (evening)
4	Run number: 9 (launchplan_final.md §1.5 referred to it as "Run #5" — stale; this is the 9th)
5	Trigger: launchplan §1.5 pre-launch pass
6
7	## Run #9 headline
8
9	Run #8 closed with "BAR MET — ALL FIVE AXES A-". Run #9 went deeper and surfaced 1 CRITICAL + 4 SERIOUS + several MED/HIGH items the prior 8 runs missed. All four launch-critical items fixed in-session; remaining items deferred with rationale below.
10
11	\| Axis \| Run #8 \| Run #9 \| Direction \|
12	\|------\|--------\|--------\|-----------\|
13	\| Payments \| A- \| A- \| flat — 2 new SERIOUS surfaced; 1 fixed (webhook unmark on dual-failure 503), 1 deferred (subscription out-of-order webhook) \|
14	\| Storage \| A- \| A- \| flat — 1 new HIGH (migration 129 dead-letter table unused) + 2 MEDs (is_s3_key_live unindexed full-scan, LIKE-suffix false-positive); deferred \|
15	\| UX Wiring \| A- → B- → A- \| A- \| dipped on grade-cap for signup TOCTOU CRITICAL, restored after fix \|
16	\| Security \| A- \| A- \| flat — 2 new SERIOUS, both fixed (JWT-bump non-atomic, 2FA email IP spoofable) \|
17	\| Performance \| A- \| A- \| flat — 2 new HIGH (per-request reqwest::Client::new in 5 hot paths, unbounded spawn in expired-account cleanup); deferred to post-launch \|
18
19	Net Run #9 (post-fix): 0 CRITICAL · 1 SERIOUS open (Payments subscription ordering — documented deferral) · 3 HIGH open (deferred) · 7 MED open (deferred). Launchplan §1.5 A- bar holds.
20
21	## Run #9 — CRITICAL fixed in-session
22
23	### UX-CRITICAL — Signup TOCTOU: race → 500 + form loss → FIXED 2026-05-31
24
25	`src/routes/pages/public/join_wizard.rs:99-139`. The wizard ran separate `get_user_by_username` / `get_user_by_email` checks before `create_user`. A concurrent signup with the same username or email slipping between SELECT and INSERT raised a 23505 unique violation that bubbled to `AppError::Database` → 500 "Something went wrong" — and the user's entire typed-in form was lost. On a public alpha-launch surge this is the highest-traffic public endpoint; the wrong page to be returning 500s on.
26
27	Fix landed: `create_user` call site now matches `AppError::Database(sqlx::Error::Database(_))` with code 23505, inspects the constraint name (`users_username_key` / `users_email_key`), and routes through `return_error(..)` with a friendly message — same flow as the explicit pre-check branches. Same shape as the existing 23505 handling in `db/license_keys.rs`, `db/builds.rs`, `routes/api/guest_checkout.rs`.
28
29	Known follow-up (not blocking): the form-reload still loses typed values on the error swap; `return_error` renders `LoginErrorTemplate` (message-only). Preserving field values would require threading them through the template — file a separate Phase 4 polish item.
30
31	## Run #9 — SERIOUS fixed in-session
32
33	### Sec-SERIOUS — `delete_all_sessions_for_user` non-atomic JWT bump → FIXED 2026-05-31
34
35	`src/db/sessions.rs:247-263`. The function ran `DELETE FROM user_sessions` then a separate `UPDATE users SET jwt_invalidated_at = NOW()` on independent connections. If the UPDATE dropped (pool timeout, conn drop, postgres restart), session cookies were dead but every outstanding SyncKit JWT survived until natural expiry — exactly the leak this function exists to prevent. The in-code comment ("a session row deleted without a JWT bump is harmless, the converse would leak access") inverted reality.
36
37	Fix landed: both writes wrapped in `pool.begin()` / `tx.commit()`. Comment updated.
38
39	### Sec-SERIOUS — 2FA login-notification email uses spoofable IP → FIXED 2026-05-31
40
41	`src/routes/pages/public/two_factor.rs:308-312`. The 2FA-completion path read `x-forwarded-for` raw (first-comma-split) for the new-login email's IP field. Every other login surface (`routes/auth.rs:242`, `auth.rs:486`, `auth.rs:528`) routes through `crate::helpers::extract_client_ip` which prioritizes `CF-Connecting-IP`. An attacker who already captured a password could pre-set `X-Forwarded-For: 1.2.3.4` on the verify-2fa POST so the "new login from <city>" email lied about origin — the exact email users are told to trust for compromise detection.
42
43	Fix landed: swapped to `crate::helpers::extract_client_ip(&headers)`. One-line change, parity restored.
44
45	### Pay-SERIOUS — Webhook dual-failure dropped events silently → FIXED 2026-05-31
46
47	`src/routes/stripe/webhook/mod.rs:73-89`. Dedup row was marked processed before handler dispatch (correct for at-least-once). On `(handler_err, insert_failed_event_err)` dual failure, code returned 503 to trigger Stripe redelivery — but Stripe's redelivery would short-circuit at the dedup check (line 50) and 200 the event without ever processing it. The code's own comment acknowledged the bug; the right tool (`unmark_event_processed`, defined 30 lines away in `db/webhook_events.rs:40`) was never called.
48
49	Fix landed: call `db::webhook_events::unmark_event_processed(&state.db, &event_id)` before returning 503, with logged-error best-effort if even that fails (same scenario where 503 was already wrong).
50
51	## Run #9 — DEFERRED with rationale (above A- bar)
52
53	### Pay-SERIOUS — Subscription webhook out-of-order events resurrect `active`
54
55	`src/routes/stripe/webhook/subscriptions.rs:90, 116, 140`. Handlers blindly overwrite `subscriptions.status` and `period_end` from the webhook payload. Stripe does NOT guarantee delivery order. Sequence `past_due → active` reordered as `active → past_due → active(stale)` overwrites a legitimate `past_due` with stale `active` — restoring access for a user who hasn't paid.
56
57	Deferral rationale: worst case is restored access for a few minutes until the next webhook arrives. Fix requires re-extracting Stripe's top-level `created` from `UntypedEvent` (currently dropped) and adding `WHERE last_event_at IS NULL OR last_event_at <= $created` guards on every status/period write across Fan+, creator-tier, and synckit code paths — non-trivial cross-cutting change. Post-launch fix in Phase 4; tracked in todo.md.
58
59	### Sto-HIGH — Migration 129 dead-letter table never written
60
61	`migrations/129_pending_s3_deletions_dead_letter.sql` creates `pending_s3_deletions_dead_letter` and documents it as "operator-visible parking lot... require manual triage." `src/scheduler/cleanup.rs:453-457` on `attempts >= 10` only logs `tracing::error!` then removes the row — never inserts into the dead-letter table. Permanently-failing keys have zero operator visibility.
62
63	Deferral rationale: operational, not runtime. No user impact; only operators lose triage signal. One-INSERT fix; bundle into Phase 4.
64
65	### Perf-HIGH — Per-request `reqwest::Client::new()` in 5 hot paths
66
67	`routes/pages/dashboard/main.rs:118`, `routes/pages/public/landing.rs:284`, `routes/api/internal/cli_features.rs:440`, `routes/api/domains.rs:319`, `auth.rs:559`. Each call builds a fresh TCP pool, TLS context, DNS resolver — no keep-alive across requests. `MtClient` in `AppState` already keeps a pooled client; the dashboard bypasses it.
68
69	Deferral rationale: real but matters at scale. Private alpha launch traffic well below where this becomes a tail-latency contributor. 30-min refactor; bundle into Phase 4 once launch traffic settles.
70
71	### Perf-HIGH — Unbounded `tokio::spawn` in expired-account cleanup
72
73	`src/scheduler/cleanup.rs:215-220` (`spawn_expired_account_cleanups`). Daily tick spawns one task per expired account, no governor. `cleanup_sandbox_accounts` (same file, ~100 lines above) correctly caps at `CLEANUP_PARALLELISM=4` via `JoinSet`; the terminated/content-removal variants don't. A backlog of 200 expired accounts fan-outs 200 concurrent S3 prefix listings racing for the 25-conn pool at midnight.
74
75	Deferral rationale: runs once daily; current expired-account count is small (private alpha). Trivial fix (lift the existing JoinSet pattern); not launch-blocking. Bundle with Phase 4.
76
77	## Run #9 — MED/LOW deferred (read-only carry-forward, in todo.md)
78
79	- Pay-MED: `pricing.rs::parse_dollars_to_cents` misinterprets European decimal comma (`1,23` → 12300¢). User-controlled input; fixable in a single regex.
80	- Pay-MED: SyncKit app-sub checkout silently defaults `storage_limit_bytes` to 0 if metadata missing.
81	- Pay-MED: Guest checkout email falls back to `"unknown@guest"` sentinel; collisions possible.
82	- Sto-MED: `is_s3_key_live` runs 7 EXISTS subqueries on unindexed `items.audio_s3_key` / `cover_s3_key` / `video_s3_key` / `versions.s3_key` etc — sequential scans per retry.
83	- Sto-MED: `is_s3_key_live` LIKE-suffix pattern `'%' \|\| s3_key` false-positives on neighboring keys (key `abc/file.png` matches `xabc/file.png`) — skips a legitimate delete → S3 object leaks.
84	- UX-MED: "Log in" return_to query param in `purchase.html:145` is dead-wired — login handler always redirects `/dashboard`. Lost purchase intent.
85	- UX-MED: Admin user filter buttons (`admin-users.html:35-44`) use `class="primary"` / `class="secondary"` instead of `btn-primary` / `btn-secondary` — renders unstyled.
86	- UX-LOW: Pagination links in `git/issues.html:72,76` don't URL-encode `search`; `&page=99` in search query corrupts pagination.
87	- UX-LOW: 5 sites do `.render().unwrap_or_default()` on Askama templates (blank UI on render failure, no log).
88	- UX-LOW: `slugify` in `formatting.rs` produces `"post"` for any non-ASCII title; international creators get opaque URLs.
89	- Sec-MINOR: `csrf.rs:176-185` `validate_token_consuming` doesn't consume — name promises stronger property than implementation.
90	- Sec-MINOR: `routes/oauth.rs:101-111` `is_localhost_redirect` allows any port on localhost regardless of registered URI.
91	- Sec-MINOR: `routes/pages/public/two_factor.rs::pending_2fa_started_at` reads `i64` via session.get; type mismatch silently → None → instantly-expired.
92	- Sec-MINOR: `scanning/archive.rs:124` path-traversal check misses lone `..` segment (no trailing separator).
93	- Perf-LOW: `scheduler/announcements.rs` linear walk through subscriber list in a single spawned task; no checkpointing.
94	- Perf-LOW: `db/page_views.rs` `pending` HashMap has no max-cardinality cap (crawler hitting 100k unique target_ids before tick).
95	- Perf-LOW: `build_runner.rs:441` local artifact tmpfile leaks if process crashes between SCP and `remove_file`.
96
97	## Run #9 — mandatory surprises
98
99	- Payments: `routes/stripe/webhook/mod.rs:82-89` literally documents the bug it ships ("the dedup row was already marked processed... Stripe won't retry") and then chooses 503 anyway. The fix (`unmark_event_processed`) sat 30 lines away in the same crate, never called. Scar-tissue-comment-without-the-fix is a recognizable pattern across the codebase.
100	- Storage: `routes/storage/mod.rs::commit_upload` sealed-helper pattern (Run #7 fix for the chronic disease) is the strongest piece of structural engineering in the repo — turned an enum into a witness type. But the neighbor file `migrations/129_pending_s3_deletions_dead_letter.sql` shows the opposite: migration written with detailed prose explaining the operator's parking lot, and the actual INSERT never wired up. Two adjacent fixes from the same audit-cycle, one structural and load-bearing, one ceremonial and silently broken.
101	- UX: `csrf.rs` `PostureMethodRouter` + sealed `CsrfManuallyValidated` witness make registering a mutation route without an explicit posture declaration uncompilable. A+ engineering. The contrast with the signup wizard's TOCTOU-and-500-with-lost-form is jarring — defensive depth on CSRF, none on the front door.
102	- Security: `routes/auth.rs:128-130` malformed-email branch skips the DUMMY_HASH timing equalizer that was added explicitly to prevent timing-side-channel user enumeration. ~2 orders of magnitude faster than every other failure path. The equalizer exists; this one path bypasses it.
103	- Performance: `db/projects.rs::get_project_ids_for_user` is the only `fetch_all` in `projects.rs` without a `LIMIT`. Its neighbor `get_projects_by_user` caps at 500 with a documented safety comment. Cyber-squatter with 10k projects + account expiry → 10k S3 prefix-deletes in one spawned task. Asymmetric defense within the same module.
104
105	## Run #9 — stress-tested OK
106
107	Verified attacks the code survived (high-confidence positives):
108
109	- Stripe webhook signature replay (HMAC constant-time, multi-secret rotation, timestamp tolerance both directions)
110	- Promo code concurrent over-use (single atomic UPDATE with max_uses + expires_at + starts_at)
111	- Cart race past pre-check (23505 fallback aborts cleanly without charging)
112	- License key prediction (6 wordlist × CSPRNG ≈ 66 bits)
113	- Pre-signed URL Content-Length binding (S3 rejects mismatch at protocol level)
114	- Storage cap atomicity (`try_replace_storage` single UPDATE)
115	- Build claim race (partial unique index + 23505 backstop)
116	- Idempotent re-confirms in all 4 upload confirm handlers (reaper-deletes-live-object closed)
117	- Session row + JWT atomicity (post-fix verified above)
118	- TOTP replay across skew window (matched-step tracked + strict `>` gate)
119	- OAuth PKCE downgrade (S256 pinned at authorize + token-exchange)
120	- CSRF body bypass via textarea-smuggled token (proper form parser)
121	- Git diff/blame XSS (HTML-escaped in attacker-controlled spots)
122	- Internal error leakage (tests assert no PG host, no S3 bucket, no sqlx variant leaks)
123
124	## Run #9 confidence per axis
125
126	- Payments HIGH (~70% LoC read this pass; Phase 4 backlog visible)
127	- Storage HIGH (full module read; cleanup.rs upper half only — MEDIUM there)
128	- UX Wiring HIGH for CSRF/error/validation; MEDIUM for wizard step partials, embed routes, dashboard CSV import
129	- Security HIGH for auth/CSRF/session; MEDIUM for scanning (YARA rule content unread), API key scoping
130	- Performance HIGH for scan worker, scheduler, storage, build_runner; MEDIUM for SyncKit, postmark, import pipeline
131
132	## Run #9 bug counts
133
134	\| Severity \| Payments \| Storage \| UX \| Security \| Perf \| Total \|
135	\|---\|---\|---\|---\|---\|---\|---\|
136	\| CRITICAL \| — \| — \| 1 (FIXED) \| — \| — \| 1 \|
137	\| SERIOUS \| 2 (1 FIXED, 1 deferred) \| — \| — \| 2 (FIXED) \| — \| 4 \|
138	\| HIGH \| — \| 1 (deferred) \| — \| — \| 2 (deferred) \| 3 \|
139	\| MED \| 3 (deferred) \| 2 (deferred) \| 2 (deferred) \| — \| — \| 7 \|
140	\| LOW/NOTE \| 2 \| — \| 3 \| 4 \| 3 \| 12 \|
141
142	## Run #9 delta vs Run #8
143
144	- 1 CRITICAL surfaced + fixed (signup TOCTOU); class missed by prior 8 runs because no agent explicitly probed the public-signup race window
145	- 4 SERIOUS surfaced; 3 fixed in-session, 1 deferred with rationale
146	- Run #8 "BAR MET" claim was correct for the surfaces it audited but understated: this pass added explicit attack-vector probing for cross-conn atomicity, IP spoof parity across auth surfaces, and webhook dedup edge paths — none of which were in prior runs' scope
147	- All previously closed Run #8 fixes verified intact (commit_upload seal, S1 tx atomicity, background.rs queue, cart MEDs)
148
149	---
150
151	# Ultra Fuzz Report — MNW Server (Run #8 — historical)
152
153	Run date: 2026-05-31
154	Run number: 8
155
156	## Run #8 Headline
157
158	\| Axis \| Run #5 \| Run #6 \| Run #7 \| Run #8 \| Direction \|
159	\|------\|--------\|--------\|--------\|--------\|-----------\|
160	\| Payments \| B \| B+ \| A- \| A- \| flat — H2 still deferred; 2 new MEDs surfaced (cart `min_price_cents` bypass, cart-all chain-break on all-free first seller) \|
161	\| Storage \| B- \| A- \| B+ \| A- \| ↑ H1 + S1 fixes verified closed; commit_upload seal intact across all 7 confirm handlers; genericization clean at every caller including synckit/blobs.rs \|
162	\| UX Wiring \| B \| A- \| A- \| A- \| flat — 1 new MED (item-wizard `pricing_model` silent fallback to "free" — same disease class fixed in project wizard at Run #6, not propagated) \|
163	\| Security \| A- \| A- \| A- \| A- \| flat — only diff in scope (username availability fail-closed) is a net improvement; MED backlog identical to Run #5/#6/#7 \|
164	\| Performance \| B- \| A- \| A- \| A- \| flat with 1 new SERIOUS — webhook `checkout_helpers.rs` unbounded `tokio::spawn` (send_purchase_emails / mailing_list / tip_email) competes with request handlers for the 25-slot pool under burst \|
165
166	Net Run #8: 0 CRITICAL · 1 SERIOUS new (Perf webhook spawn) — FIXED 2026-05-31 · 5 new MED — ALL FIXED 2026-05-31 · 1 SERIOUS previously-deferred (Payments H2 `claim_free_project` soft race) — FIXED 2026-05-31.
167
168	Post-Run #8 status (2026-05-31 end-of-day): 0 CRITICAL · 0 SERIOUS · 0 MED open from any prior run. All five axes A-, all above-MED items closed, all Run #8 MEDs closed, prior-deferred SERIOUS closed. Launchplan §1.5 bar fully cleared.
169
170	2026-05-31 post-Run-#8 backlog sweep (7 waves): 24 of 26 carried MED/LOW/NOTE items closed across Storage (5), Security (8), Performance (3), UX (2), Payments (2), Auth (4). Two deferred with rationale: `build_runner.rs` serial targets (LOW, builds run rarely, refactor touches denominator) and `scheduler/mod.rs` advisory-lock granularity (multi-replica concern, single-process today). New schema migration `133_items_duration_seconds_nonnegative.sql` pins the negative-duration invariant in the DB. New `commit_rescan` helper extends the chronic-disease commit_upload seal to admin paths. Tests: 1655 / 0.
171
172	Launchplan §1.5 bar: ALL 5 AXES AT A- — BAR MET. The new Perf SERIOUS is axis-internal and the agent kept Perf at A- (machinery wins outweigh; same shape as previously-closed `record_view` per-request spawn — apply mpsc + drainer pattern). New Payments MEDs and UX MED are launch-quality items worth addressing or documenting before ship; none are A- blockers.
173
174	## Run #8 — new findings above MED
175
176	### P-SERIOUS — Webhook hot-path unbounded `tokio::spawn` (Performance) — FIXED 2026-05-31
177	`src/routes/stripe/webhook/checkout_helpers.rs:58, 96, 124, 290` + `src/routes/stripe/webhook/checkout.rs:618`. `send_purchase_emails`, `subscribe_buyer_to_mailing_list`, `send_tip_email`, `send_guest_sale_notification`, guest-purchase-confirmation each `tokio::spawn` from the webhook handler. Multi-item cart fires N spawns per webhook; each task acquires 1-2 pool conns + a Postmark call. No JoinSet, no cap. Under burst, hundreds of detached tasks competed with request handlers for the 25-slot pool. Same shape as the Run #4 `record_view` per-request spawn (fixed via mpsc + drainer).
178
179	Fix landed: new generic `src/background.rs` module — `BackgroundTx` + `spawn_pool()` with bounded mpsc (capacity 1024) + semaphore-bounded concurrent execution (8 workers, well below `DB_POOL_MAX_CONNECTIONS=25`). `state.bg.spawn(name, fut)` is non-blocking; queue overflow logs a warning and drops the task. The `spawn_email!` macro was refactored to use the bg queue (covers 17 callers across auth/admin/follows/library/two_factor/stripe webhook/login flows). The 5 manual webhook `tokio::spawn` sites were also migrated. Per-request email sends from postmark issue replies (×2), guest-claim email, and join-wizard signup (×2) were migrated in the same pass — same disease, same fix.
180
181	Out of scope for this fix (different bug shapes; defer to Phase 4 polish or own remediation): import pipeline (long-running, needs own bound), MT community creation (single outbound HTTP, minor pool pressure), creator departure notification + status broadcast (broadcast-class — use `broadcast.rs` JoinSet pattern), idempotency-store post-response (trivial DB write), build_runner (already gated by claim flow), scheduler/monitor/scanning/page_views (background workers, not per-request).
182
183	### Payments MED — Cart `min_price_cents` bypass — FIXED 2026-05-31
184	Both cart paths (`process_seller_checkout` and `create_cart_checkout`) now check `pc.min_price_cents` for non-platform Discount codes before applying the discount. Cart skips the ineligible item (others may still qualify) rather than rejecting the whole cart — matches the existing scope-skip pattern.
185
186	### Payments MED — Cart-all chain-break on all-free first seller — FIXED 2026-05-31
187	`process_seller_checkout` signature changed `Result<String>` → `Result<Option<String>>`; all-free path now returns `Ok(None)` instead of `Err(BadRequest)`. New `drain_to_paid` helper loops through the queued sellers until a paid one is reached (returns URL) or queue exhausted (returns `Ok(None)` → library redirect). Both callers (`create_cart_checkout_all` and `checkout_success`) updated to use it.
188
189	### UX MED — Item wizard `pricing_model` silent fallback — FIXED 2026-05-31
190	`save_pricing` now rejects missing pricing_model with `AppError::validation("Select a pricing model")` and rejects unknown values with `format!("Unknown pricing model: {other}")`. Same shape as the project wizard Run #6 fix.
191
192	### UX MED — Inline-JS template duplication — FIXED 2026-05-31
193	Added delegated `data-copy-link` click handler to `static/mnw.js` with proper `.catch()` (falls back to `window.prompt` in non-secure contexts — better than the silent-no-op the inline snippets shipped with). 8 templates migrated from `onclick="navigator.clipboard.writeText(...).then(...)"` to `<a href="..." data-copy-link>Copy link</a>` (audio_player, blog_post, collection, item, project, text_reader, user, video_player). `href` is the real URL so middle-click / no-JS / share menus still work. Cache-bust query bumped to `v=0531`.
194
195	### Perf MED — Cart free-claim N+1 — FIXED 2026-05-31
196	Extended `CartItem` with `enable_license_keys` + `default_max_activations` (both cart queries pull them through). Three free-claim loops (single-seller paid path, discount-zeroed promo path, chain-flow path) drop the per-item `get_item_by_id` and replace per-item `remove_from_cart` DELETE with a single bulk `remove_from_cart_bulk(..., ANY($2))` at the end of each loop. Per-item tx for `claim_free_item` stays (the per-item claim-vs-already-purchased return value is load-bearing for sales-count increment). Roundtrips per free item dropped from ~5-7 to ~3-4; per-loop DELETEs from N to 1.
197
198	## Run #8 — verified standing (storage fixes from session)
199
200	- H1 (`uploads.rs::confirm_upload` L295-337) — three-arm match correct. Zero-rows arm rolls back (replace path = `try_replace_storage` swap-back with `i64::MAX` cap; fresh-upload path = `decrement_storage_used`), then `enqueue_s3_orphan(new_key)`, returns BadRequest "Item was modified concurrently." Returns BEFORE `commit_upload` and BEFORE `remove_pending_upload` — pending_uploads row left as reaper second-line defense.
201	- S1 (`media.rs::media_confirm` L241-293) — single `state.db.begin()` wraps storage credit + pending_uploads clear + media_files INSERT. S3 IO entirely outside tx. tx drop → Postgres ROLLBACK → all three writes reverted atomically. 23505 detection via typed `AppError::Database(sqlx::Error::Database(...))` pattern works post-rollback. S3 cleanup fires on every tx-failure branch.
202	- Genericization — `pending_uploads::remove_pending_upload` and `media_files::create` now `impl PgExecutor<'e>`. All 12 callers (including `synckit/blobs.rs:157`) still compile and execute correctly.
203	- Pool pressure delta from S1 tx — neutral-to-better. Prior code grabbed 3 separate conns serially; new code grabs 1 conn for ~3× the duration. Users-row write lock held ~ms. Per-user serialization for sub-second uploads acceptable.
204
205	## Run #8 — mandatory surprises
206
207	- Payments: `compute_splits` more careful than its comment promises — remainder-distribution loop constrained by `expected_total = amount * raw_total_pct.min(100) / 100`, so under-100% splits keep the owner's share AND distribute floor-rounding remainders up to bound. Proptest-style invariant tests fully fence it.
208	- Storage: `try_increment_storage_on` inside the tx holds a row-level lock on `users` for the duration of the tx. Not a bug (sub-ms hold; cap can't be over-shot via WHERE re-evaluation under READ COMMITTED). But every media confirm now serializes per-user against every other storage write.
209	- UX: Copy-link button is a chimera. Nine templates copy the same inline `onclick` that calls `navigator.clipboard.writeText`, mutates `this.textContent` to `"Copied!"` — silently broken in any tab loaded over plain HTTP, in iframes, or with restrictive CSP. No `.catch()` → no fallback, no error.
210	- Security: `routes/auth.rs:128-130` malformed-email branch skips DUMMY_HASH timing equalizer. ~2 orders of magnitude faster than every other failure path — distinguishes "you submitted an invalid-email-shaped string" from "valid email, unknown account." Real timing oracle a few lines above the equalizer that was deliberately added to prevent exactly this.
211	- Performance: `metrics::idempotency_middleware` does a DB SELECT on EVERY POST/PUT with an `Idempotency-Key` header BEFORE the handler runs. No bloom filter, no negative cache. ~1 extra ms per POST already doing 2-5 DB queries — free 20%+ on POST p50 available by adding an in-memory `seen` set.
212
213	## Run #8 bug counts
214
215	\| Severity \| Payments \| Storage \| UX \| Security \| Perf \| Total \|
216	\|---\|---\|---\|---\|---\|---\|---\|
217	\| CRITICAL \| — \| — \| — \| — \| — \| 0 \|
218	\| SERIOUS \| 1 (deferred) \| — \| — \| — \| 1 (new) \| 2 \|
219	\| MED \| 2 (new) \| 7 \| 5 \| 8 \| 5 \| 27 \|
220	\| LOW/NOTE \| 5 \| 3 \| 4 \| 3 \| 2 \| 17 \|
221
222	## Run #8 confidence per axis
223
224	- Payments HIGH (~70% LoC read)
225	- Storage HIGH (full)
226	- UX HIGH
227	- Security HIGH (scoped); MEDIUM for storage-route auth side-effects
228	- Performance HIGH
229
230	## Run #8 delta vs Run #7
231
232	- Storage B+ → A-. H1 + S1 fixes verified closed. Genericization clean.
233	- Payments A- flat. 2 new MEDs (cart `min_price_cents` bypass, cart-all chain-break) surfaced via expanded coverage; H2 deferred unchanged.
234	- UX A- flat. 1 new MED (item-wizard `pricing_model` silent fallback) — same disease class as project wizard fix from Run #6, not propagated.
235	- Security A- flat. Net improvement (username fail-closed). MED backlog identical.
236	- Performance A- flat. 1 new SERIOUS (webhook unbounded spawn) — same shape as Run #4 `record_view` fix. Cart free-flow N+1 (MED) — Run #5 fix covered paid only.
237
238	---
239
240	# Ultra Fuzz Report — MNW Server (Run #7 — historical)
241
242	Run date: 2026-05-31
243	Run number: 7 (+ S1 + Storage code-fuzz fixes confirmed in Run #8)
244
245	## Headline
246
247	\| Axis \| Run #5 \| Run #6 \| Run #7 \| Direction \|
248	\|------\|--------\|--------\|--------\|-----------\|
249	\| Payments \| B \| B+ \| A- \| ↑↑ Phase 2 + Run #6 + Run #7 fixes all landed; S1 cart 23505 swallow fixed post-Run #7; H2 claim_free_project soft race deferred \|
250	\| Storage \| B- \| A- \| B+ → A- pending Run #8 \| ↑/↓ commit_upload structural fix is excellent; Run #6 idempotency fix introduced HIGH-1 (pending_uploads leak in 4 sites) + HIGH-2 (missing rollback on update_*_url) — both fixed post-Run #7. Storage code-fuzz 2026-05-31 surfaced H1 (confirm_upload silent zero-rows + side-effects-already-fired) and reopened S1 media_confirm tx atomicity — both fixed in same session \|
251	\| UX Wiring \| B \| A- \| A- \| ↑ field-aware deletion + parse_dollars_to_cents shared; pricing_model silent fallback HIGH found and fixed post-Run #7 \|
252	\| Security \| A- \| A- \| (unchanged) \| flat — no security-touching changes in Runs #6/#7 \|
253	\| Performance \| B- \| A- \| (unchanged) \| flat — no perf-touching changes in Runs #6/#7 \|
254
255	## Post-Run #7 Storage code-fuzz (2026-05-31)
256
257	Targeted code-fuzz scoped to the Storage axis to verify A- before triggering full Run #8. Two findings above MED, both fixed in-session:
258
259	- H1 (HIGH) — `routes/storage/uploads.rs::confirm_upload` silent `rows_affected = 0`. Same shape as the just-closed HIGH-2 (`update__url`), one step further along the same handler family. UPDATE at L295 uses ownership-filter `WHERE id = $1 AND project_id IN (SELECT id FROM projects WHERE user_id = $4)`; `rows_affected()` was never checked. If the item was deleted between `get_item_owner` (L156) and the UPDATE, storage credit stayed incremented, `pending_uploads` got cleared a few lines down, and `commit_upload` enqueued a scan job against a ghost target — permanent S3 leak + over-charged counter. Fix:* three-arm match on the UPDATE result; zero-rows case rolls back storage and routes the new S3 key through `enqueue_s3_orphan` so the reaper still cleans it, then returns BadRequest "Item was modified concurrently."
260	- S1 (SERIOUS, Run #5 plan #12 reopened) — `routes/storage/media.rs::media_confirm` three-write atomicity. Run #5 called for wrapping `try_increment_storage` → `remove_pending_upload` → `media_files::create` in a transaction; Run #7's in-process compensation only covered in-process errors. Process interruption (panic, OOM kill, container restart) between any two writes still leaked. Fix: all three writes now in a single tx; tx drop rolls back storage + pending_uploads + media_files atomically. Only the S3 object needs explicit cleanup (single `delete_object` after rollback). Supporting DB-layer changes: `creator_tiers::try_increment_storage_on(&mut PgConnection)` tx-friendly variant; `pending_uploads::remove_pending_upload` and `media_files::create` signatures genericized to `impl PgExecutor<'e>` (backwards compatible).
261
262	Remaining storage MED/LOW (below launchplan §1.5 A- bar; ride into Phase 4 polish or document deferral):
263	- MED — `update_project_image_url` / `update_item_cover` ignore `rows_affected()` (same shape as H1; mitigated for current callers because the only follow-on side-effect is `bump_cache_generation`).
264	- MED — `downloads.rs:120` `((duration as u64) * 2).max(3600)` with no DB `CHECK (duration_seconds >= 0)`. Negative duration → multi-decade presigned URL. Exploitability requires creator-controlled negative duration; ffprobe doesn't produce them. Cap in code + add CHECK migration.
265	- MED — Admin rescan paths (`routes/admin/uploads.rs:347, 390`) call `db::scan_jobs::enqueue` directly, bypassing the `commit_upload` structural seal. Ordering is correct so no live bug; demote `db::scan_jobs::enqueue` to `pub(crate)` and expose `commit_rescan(target, ...)` to close the chronic-disease finding for real.
266	- MED — `enqueue_s3_orphan` single-policy doc in `routes/storage/mod.rs:24-30` overstates the discipline; many `s3.delete_object(...).await.ok()` direct calls remain at pre-storage-credit rejection paths. Tighten the doc or migrate the post-storage-credit sites.
267	- MED — `is_s3_key_live` doesn't enumerate project image URLs (project cover keys live in a distinct prefix so no current bug; surface is fragile if future code paths queue project image keys).
268	- LOW — `scanning/worker.rs:251` inline `UPDATE media_files SET scan_status` instead of `db::scanning::update_media_file_scan_status` helper.
269	- LOW — `routes/pages/dashboard/wizards/item/save.rs:95` `update_item_cover_image_url` updates only `cover_image_url` (not s3_key/size); client-side hidden-field abuse can desync.
270	- LOW — `db/pending_uploads.rs::remove_pending_upload` deletes by s3_key alone (per-handler prefix validation makes cross-user collision unreachable, but the function signature is broader than it needs to be).
271
272	Chronic disease status (5th run): The invariant-in-prose / sibling-not-swept pattern that recurred across Runs #2–#6 was structurally addressed in Run #7 via two helpers:
273	- `routes/storage/mod.rs::commit_upload(target: CommitTarget, ...)` — sealed `enqueue_scan_for` to module-private; the helper is now the only handler-reachable path for scan enqueue + scan_status flip after a DB write. Bug shapes 1–3 from prior runs are now structurally impossible to introduce in a new sibling.
274	- `crate::pricing::parse_dollars_to_cents` + `validate_dollars_f64` — canonical dollar-to-cents conversion; bypassing has historically introduced NaN→$0 and saturating-overflow silent bugs.
275
276	Net after Run #7 + S1 fix: 0 CRITICAL · 0 HIGH/SERIOUS · 1 SERIOUS deferred (Payments H2 soft race on `claim_free_project`) · a handful of MED/LOW polish items.
277
278	---
279
280	# Ultra Fuzz Report — MNW Server (Run #5 — historical)
281
282	Run date: 2026-05-30
283	Run number: 5
284
285	## Headline
286
287	\| Axis \| Run #4 \| Run #5 \| Direction \|
288	\|------\|--------\|--------\|-----------\|
289	\| Payments \| A- \| B \| ↓ (Run #4 plan items closed; 4 new SERIOUS surfaces previously unaudited: NULL item_id refund, splits >100% overflow, tip project authorization, cart unlisted bypass) \|
290	\| Storage \| A- \| B- \| ↓ (Run #4 `images.rs` ordering bug closed; same disease reappeared in `uploads.rs` route gate ordering — file-type rejection runs AFTER scan enqueue) \|
291	\| UX Wiring \| C+ \| B \| ↑ (Run #4 CSRF patchwork + creator-tier token fixed and structurally enforced; new CRIT: field-aware validation API is dead code at template boundary) \|
292	\| Security \| B+ \| A- \| ↑ (Run #4 git-shell validation, lockout email flood, CSRF policy all verified; no new CRIT/HIGH; remaining gaps are operational/MED) \|
293	\| Performance \| B \| B- \| ↓ (Run #4 scan_jobs retention + pool permit + broadcast bounding verified; new HIGHs in previously unaudited cart checkout + page-view paths + scheduler integrity scan) \|
294
295	Net: 3 CRITICAL (vs Run #4: 4), 13 HIGH/SERIOUS (vs Run #4: 10), 11 MED, 9 MINOR/LOW. Two axes regressed because Run #5 reached previously-unaudited territory (Payments tip/cart/refund edges; Performance hot-path request loops) while Run #4 plan items themselves were correctly closed. The Storage regression is a recurrence of the same shape in a sibling handler — the chronic invariant-in-prose disease, fourth consecutive run.
296
297	## Critical / High Findings (fix before launch)
298
299	1. [Storage — CRITICAL] `routes/storage/uploads.rs:204-237` — `confirm_upload` calls `enqueue_scan_for(...)` and `update_item_scan_status(... Pending)` BEFORE the match arm rejects `Download`/`Insertion`/`MediaImage`/`MediaVideo` with `BadRequest`. A misrouted-but-valid `item_id` confirms flips that item's scan status to Pending, blocks `stream_url` for every fan, and leaks a scan-job row for an S3 key that's then deleted.
300	2. [UX — CRITICAL] `error.rs:216-264` + `templates/error.html` — `AppError::validation_fields(summary, [(field, msg), ...])` is consumed only by unit tests. `ErrorTemplate` has no `fields:` member; no template renders per-field highlights. Every non-HTMX validation failure degrades to the global "Go Home / Go Back" page and wipes submitted form input. Handler authors are misled into thinking their carefully-tagged field errors reach the UI.
301	3. [Perf — CRITICAL] `build_runner.rs:175-180` — Partial-failure error message reports `("{}/{} succeeded", artifact_keys.len(), artifact_keys.len() + 1)`. Denominator is always `succeeded + 1`, regardless of how many targets actually ran. Three targets, one succeeded, two failed → reports "1/2" (should be 1/3). Failed-target count is never tracked.
302
303	### HIGH / SERIOUS
304
305	4. [Payments — SERIOUS] `db/transactions.rs:699-716` — `refund_transaction_by_payment_intent` returns `Vec<(TransactionId, ItemId)>` (non-Optional). Project-level transactions store `item_id IS NULL` (`routes/stripe/checkout/project.rs:135`). On `charge.refunded` for a project-level purchase, sqlx fails to decode NULL → `ItemId`; webhook handler 5xx's; Stripe retries forever.
306	5. [Payments — SERIOUS] `routes/stripe/webhook/checkout_helpers.rs:240-269` — `compute_splits` comment says "Defensive clamp: a misconfigured project_members row could sum past 100%" but the loop only adds remainder pennies and never subtracts. Two members at 60%+60% on $10 each are credited $6 each — $12 of $10 of revenue. Clamp only affects `expected_total`, never the already-computed per-member amounts. Tests cover ≤100% only.
307	6. [Payments — SERIOUS] `routes/stripe/checkout/tips.rs:104-106` — `TipForm.project_id` is taken verbatim from the form. The webhook later calls `record_tip_splits(tip.id, tip.project_id, ...)` and credits THAT project's members. An attacker tipping creator A can pass project B's UUID; B's members get split obligations credited against A's tip. Stripe money flows correctly; on-platform `tip_splits` records and any downstream reporting are corrupted.
308	7. [Payments — SERIOUS] `db/cart.rs:94-123` + `routes/stripe/checkout/cart.rs` — `item.rs:47-49` enforces "Unlisted items can only be obtained through their bundle" via `if !item.listed`. `toggle_cart_preflight` and `get_cart_items` check `is_public` but NOT `listed`. An attacker who knows an unlisted item's UUID can POST to `/api/cart/{id}/toggle` and check out via the cart flow, fully bypassing the bundle-only gate.
309	8. [Payments — SERIOUS] `routes/stripe/webhook/subscriptions.rs:117-121, 67-69, 95-96` — `status_str.parse::<SubscriptionStatus>()` returns BadRequest for any status not in `enums.rs:183-198` (Stripe's `paused` is new). Webhook handler returns Err; scheduler retries forever until status changes.
310	9. [Payments — SERIOUS] `payments/webhooks.rs:294-308` — `is_full_refund` returns true when `amount_refunded >= amount` and both are zero (Stripe sometimes emits these for $0 verification charges). Triggers `refund_transaction_by_payment_intent` with default `unknown` intent ID. Test at line 517-525 pins the behavior.
311	10. [Storage — HIGH] `routes/storage/versions.rs:159-174` — `version_confirm_upload` enqueues scan and flips `scan_status` to Pending BEFORE the `version.s3_key == req.s3_key` idempotency check at line 172. Duplicate retry of an already-confirmed upload knocks a Clean version back to Pending, breaking downloads.
312	11. [Storage — HIGH] `routes/storage/images.rs:179-208` — `project_image_confirm` replace branch is gated on `Ok(Some(old_size))` from `s3.object_size(&old_key)`. On `Err` (S3 hiccup) or `Ok(None)` (URL with no object behind it) it falls into the "no old image" branch, `try_increment_storage` without decrementing. Permanent storage over-count. Also: `update_project_image_url` runs AFTER `enqueue_deletions` of the old key, with no rollback path.
313	12. [Storage — HIGH] `routes/storage/media.rs:236-293` — `media_confirm` does three separate writes (`try_increment_storage`, `remove_pending_upload`, `media_files::create`) outside a transaction. Interruption between steps leaves S3 object orphaned with storage credit consumed and no DB row.
314	13. [UX — HIGH] `routes/pages/dashboard/wizards/item/save.rs:183-185, 214-227` — `let price_cents = (price_dollars * 100.0).round() as i32; if price_cents > 0 { validate_price_cents(price_cents)?; }`. Guard skips validation for 0 and negative values; value goes through `PriceCents::from_db` (no validation) into `update_item`. Submitting `price=-5` writes `-500` cents. Same pattern on PWYW: no `min <= suggested` check.
315	14. [UX — HIGH] `routes/pages/dashboard/wizards/item/save.rs:179-183` + `routes/api/items/bulk.rs:136-139` + `routes/pages/dashboard/wizards/project.rs:264-298` — `price_dollars: f64 = …parse()…unwrap_or(0.0)`. `"NaN".parse::<f64>()` succeeds; `NaN as i32 == 0` (silent Free). `1e20` saturates `i32::MAX`. Bulk path catches via `PriceCents::new` cap; `save.rs` does not — persists raw.
316	15. [UX — HIGH] `routes/auth.rs:356-361` — `let is_taken = db::users::get_user_by_username(...).await.map(\|u\| u.is_some()).unwrap_or(false);`. Transient DB error during signup live-check returns "available", misleading the user; subsequent signup races whatever real state the DB is in.
317	16. [Perf — HIGH] `routes/stripe/checkout/cart.rs:68-248` — Per cart item: sequential `has_purchased_item`, optional `remove_from_cart`, per-free-item `begin tx → claim_free_item → increment_sales_count → commit`, `get_item_by_id`, second `remove_from_cart`. 20-item cart ≈ 80 sequential roundtrips, ~20 separate transactions, 20 distinct pool acquisitions in series.
318	17. [Perf — HIGH] `db/page_views.rs:18-32` — `record_view` spawned per public request, takes a pool connection to UPSERT. With `DB_POOL_MAX_CONNECTIONS = 25`, a viral item link spawns unbounded tasks, eats the pool, times out real request handlers at acquire. No batching, no per-(target,session) debounce.
319	18. [Perf — HIGH] `scheduler/integrity.rs:53-73` — `check_sales_count_drift`: `SELECT i.id, i.sales_count, COUNT(t.id) FROM items LEFT JOIN transactions ... GROUP BY i.id HAVING i.sales_count != COUNT(t.id) LIMIT 50`. `HAVING` post-aggregation; Postgres scans every row in `items` and joins every completed transaction in history before filtering. `LIMIT 50` doesn't cap the work. Weekly multi-minute query holding a pool connection.
320
321	## Scorecard
322
323	### Axis Summary Grades
324
325	\| Axis \| Overall \| Cold Spots \| Mandatory Surprise \|
326	\|------\|---------\|------------\|--------------------\|
327	\| Payments \| B \| `routes/stripe/checkout/cart.rs` (B-), `routes/stripe/checkout/tips.rs` (B-), `db/transactions.rs` (B-), `routes/stripe/webhook/checkout_helpers.rs` (B-), `routes/stripe/webhook/subscriptions.rs` (B) \| `compute_splits` carries a "Defensive clamp" comment that explicitly anticipates the >100% case and then fails to defend against it — only `expected_total` is clamped, the already-computed per-member splits go unchanged. Treat as evidence the defensive-comment culture is itself unreliable; comments and code drift independently. \|
328	\| Storage \| B- \| `routes/storage/uploads.rs` (C+), `routes/storage/images.rs` (C+), `routes/storage/versions.rs` (C+), `routes/storage/media.rs` (B-), `db/mod.rs::check_sandbox_cap` (C+) \| `stream_url` (`downloads.rs:119-122`) computes presigned expiry as `((duration as u64) * 2).max(3600)` where `duration: i32` and no DB CHECK ≥ 0 exists on `duration_seconds`. A negative value becomes near-`u64::MAX` expiry — a centuries-long presigned URL. The cast width and missing CHECK are independent latent bugs that compose into a multi-decade credential leak. \|
329	\| UX Wiring \| B \| `routes/pages/dashboard/wizards/item/save.rs` (B-), `error.rs` (B-), `routes/pages/public/discover.rs` (B) \| `update_item` takes ~13 positional `Option`s; call sites are unreadable and error-prone. The negative-price bug (HIGH #13) is born from this signature: anyone calling it has no compiler help distinguishing `Some(-500)` (bug) from `Some(500)` (intent). \|
330	\| Security \| A- \| `helpers.rs` (B+), `scanning/clamav.rs` (B), `scanning/yara.rs` (B), `rate_limit.rs` (B+) \| The "11 layer" scan pipeline test gives a false sense of coverage. ClamAV is `FailOpen` by explicit policy (`scanning/clamav.rs:19`), YARA silently skips rule files that fail to compile (`scanning/yara.rs:54-67`), and there is no startup assertion that any real AV layer is live. A misconfigured deploy can pass EICAR as Clean while the test suite is green. \|
331	\| Performance \| B- \| `routes/stripe/checkout/cart.rs` (C), `scheduler/announcements.rs` (C+), `scheduler/integrity.rs` (C+), `scheduler/cleanup.rs` (B-), `build_runner.rs` (B-), `db/page_views.rs` (C+), `db/pending_s3_deletions.rs` (B) \| The biggest scaling cliff is a 1-line `tokio::spawn` on the page-view path, not anything that "looks expensive". Hot-path response shipped its tail-latency problem to the same pool that serves it. \|
332
333	## Bug Counts by Severity
334
335	\| Severity \| Payments \| Storage \| UX \| Security \| Perf \| Total \|
336	\|---\|---\|---\|---\|---\|---\|---\|
337	\| CRITICAL \| — \| 1 \| 1 \| — \| 1 \| 3 \|
338	\| HIGH/SERIOUS \| 5 \| 3 \| 3 \| — \| 3 \| 14 \|
339	\| MED \| 2 \| 3 \| 2 \| 4 \| 2 \| 13 \|
340	\| MINOR/LOW \| 2 \| 2 \| 2 \| 3 \| 1 \| 10 \|
341
342	## Cross-Cutting Concerns
343
344	1. Side-effects-before-validation pattern. Storage (uploads/versions/images route gates run after scan enqueue), Payments (tip `project_id` accepted before authorization, cart `listed` not checked before checkout), UX (price `from_db` after a guard that skips zero/negative). Four files, three axes, same shape: persist first, validate later.
345	2. Invariant-in-prose, fourth consecutive run. Run #2→#3 was MaybeUser; Run #3→#4 was scan_status ordering comments-vs-code; Run #4 partial fix landed (`images.rs`) but the same disease moved up a layer to `uploads.rs` (the route-level file-type gate now runs after scan enqueue). The Payments "defensive clamp" comment in `compute_splits` is the same shape on a different organ. No type-level constructive impossibility has yet been applied to any of these.
346	3. Optional positional args as bug carriers. `update_item`'s ~13 positional `Option`s let the wizard pass a negative-price `Option<PriceCents::from_db>` past the validator. Same pattern is implicated in the UX field-error finding — `ErrorTemplate`'s struct literal is missing a `fields:` field at every callsite and the compiler doesn't care.
347	4. Hot-path pool pressure from fire-and-forget writes. `record_view` per pageview, `tokio::spawn` per cart line, scheduler advisory-lock conn pinned across S3. The 25-connection pool is sized for a quiet box; three independent fan-out patterns can each saturate it.
348	5. FailOpen with no liveness assertion. ClamAV FailOpen + YARA optional + no startup gate = a green test suite can coexist with zero real AV coverage. Same shape as the Performance "spawned task accumulates without bound" pattern — both are silent degradations the operator never sees.
349
350	## Components Successfully Stress-Tested
351
352	- All Run #4 Phase 1 closures verified standing (CSRF creator-tier token, `images.rs` scan_status ordering structural fix, git-shell validation, lockout `=` predicate, promo dedupe, scanner streaming + pool permit, broadcast bounded fan-out, scan_jobs retention).
353	- Stripe HMAC: multi-secret `v1=` rotation now accepts on any match (Run #4 polish landed).
354	- Promo `try_increment_use_count` race-free via atomic single-row UPDATE; release path uses detach for no-double-decrement; proptest-covered.
355	- License keys: 66-bit entropy, DB UNIQUE, `FOR UPDATE` activation, full recount on revoke (display lag only — finding #M).
356	- CSRF posture: `CsrfRouter<S>` newtype prevents a bare `Router::route(path, post(...))` from compiling in mutation-bearing files. Verified.
357	- Argon2id parameters + `DUMMY_HASH` timing equalization on user-not-found (login, OAuth, SyncKit).
358	- PKCE-S256 pinned at both authorize and token endpoints; OAuth code atomic single-use consume.
359	- JWT future-iat rejection + `jwt_invalidated_at` second-equal `<=` semantics; password change bumps `jwt_invalidated_at` via `update_user_password`.
360	- SSE shard-guard drop-before-remove; cross-process advisory locks for scheduler ticks.
361	- ZIP bomb: decompressed-bytes counted (not claimed); ratio + depth caps; nested magic-byte detection.
362	- `try_increment_storage` cap-predicate UPDATE; concurrent uploads cannot both squeeze past cap.
363
364	## Confidence Per Axis
365
366	- Payments HIGH — read 22 of 23 listed files end-to-end with targeted attacks per surface; all four SERIOUS reproducible by line-tracing.
367	- Storage HIGH — CRITICAL and all three HIGHs mechanically reproducible; mandatory surprise composes two latent bugs via line-by-line read.
368	- UX Wiring HIGH — full read of `csrf.rs`, `error.rs`, `markdown.rs`, `formatting.rs`, `validation/mod.rs`; spot-checked 20+ templates for CSRF pattern; CRITICAL field-aware-validation finding cross-checked by grepping `validation_fields_ref` callers.
369	- Security MEDIUM — auth/CSRF/OAuth/scanning surfaces walked thoroughly; admin/moderation/reports/ssh_keys API/totp routes only sampled. ClamAV FailOpen is policy not bug; flagged as architectural risk.
370	- Performance MEDIUM-HIGH — spot-checked DB call patterns across 15+ files; exhaustive route-level N+1 sweep deferred; stripe/webhook code shows similar `for x in &xs` loops at `checkout.rs:149,167,198,452` that were not deep-audited.
371
372	## Metrics
373
374	- Modules audited: ~80
375	- Cold spots (≤ B): 18
376	- Bugs: 3 CRITICAL, 14 HIGH/SERIOUS, 13 MED, 10 MINOR/LOW
377	- Axes at A- or above: 1/5 (Security)
378
379	## Delta Since Run #4
380
381	FIXED (Run #4 items not surfaced this run):
382	- All 10 Run #4 Phase 1 items verified closed (CSRF creator-tier, `images.rs` ordering, git-shell validation, lockout email flood, cancel_pending CSRF, promo dedupe, scanner streaming + pool permit, scan_jobs retention, broadcast bounding).
383	- All 7 Run #4 Phase 2 items verified closed (cart template price math, media reupload race, pending_uploads reaper bump, TOTP step-replay, delete_other_sessions cache eviction, `/login` CSRF, OAuth fetch_optional).
384	- All 5 Run #4 Phase 3 items verified closed (claim_pending_build partial index, build status reaper race, `extract_s3_key_from_url` host pinning, TOTP `pending_2fa` tracking row, KNOWN_SYNC_APPS removed entirely).
385	- All Phase 4 polish items verified closed.
386
387	NEW CRITICAL/HIGH in Run #5 (previously unaudited or regressed):
388	- Storage: `uploads.rs` route-level file-type gate runs after scan enqueue (CRIT).
389	- UX: `validation_fields` plumbing is dead code at template boundary (CRIT).
390	- Perf: `build_runner.rs` partial-failure denominator nonsense (CRIT).
391	- Payments: NULL `item_id` decode bomb on project-level refunds (SERIOUS).
392	- Payments: `compute_splits` over-credits when project_members sum >100% (SERIOUS).
393	- Payments: tip `project_id` not validated vs recipient (SERIOUS).
394	- Payments: cart bypasses item `listed` gate (SERIOUS).
395	- Payments: unknown subscription status retry storm (SERIOUS).
396	- Storage: `version_confirm_upload` scan enqueue before idempotency check (HIGH).
397	- Storage: `project_image_confirm` mis-accounts on S3 probe failure + no rollback (HIGH).
398	- Storage: `media_confirm` non-atomic three-write sequence (HIGH).
399	- UX: negative/NaN price acceptance via `PriceCents::from_db` after permissive guard (HIGH).
400	- UX: username availability check fails open on DB error (HIGH).
401	- Perf: cart checkout 80 sequential roundtrips (HIGH).
402	- Perf: `record_view` unbounded spawn per public request (HIGH).
403	- Perf: `check_sales_count_drift` full-table aggregate (HIGH).
404
405	CHRONIC (across Run #3 → Run #4 → Run #5):
406	- Invariant-in-prose / policy-not-in-types — FOURTH consecutive run. Run #4 partially fixed the scan_status ordering inside `images.rs` (and the CSRF policy via `CsrfRouter` structurally), but the same disease moved up a layer: in `uploads.rs` the route-level file-type gate now runs after scan enqueue. The constructive-impossibility shape needed: extract a `commit_upload(file_type, ...)` higher-level operation that validates the file_type before doing any scan/credit side effects, then make `enqueue_scan_for` + `update_*_scan_status` `pub(crate)` so handlers cannot call them directly. The Payments `compute_splits` "Defensive clamp" comment + the UX `validation_fields_ref` orphan plumbing are the same disease in different organs.
407
408	REGRESSED:
409	- Payments (A- → B) — four new SERIOUS bugs surfaced in previously-unaudited tip/cart/refund/subscription-status corners. Not a regression in fixed code; a regression in audit coverage.
410	- Storage (A- → B-) — invariant-in-prose recurrence (chronic above).
411	- Performance (B → B-) — hot-path request loops audited for the first time.
412
413	---
414
415	# Plan: Restore Every Axis to A- or Higher (Run #5)
416
417	Target grades: Payments A · Storage A · UX A- · Security A- · Performance A-.
418
419	User priority for the launch window: resolve every CRITICAL/SERIOUS/HIGH before re-running. Iterate until audits surface only small new errors.
420
421	## Phase 1 — CRITICAL (fix today)
422
423	1. Storage CRIT — `uploads.rs` file-type gate ordering. `routes/storage/uploads.rs:204-237`. Move the match arm that rejects `Download`/`Insertion`/`MediaImage`/`MediaVideo` BEFORE `enqueue_scan_for` and `update_item_scan_status`. Then make `enqueue_scan_for` + `update_*_scan_status` `pub(crate)` and expose a `commit_upload(file_type, item_id, s3_key)` higher-level op that performs validation → credit → row insert → status flip in the correct order. The same constructor must serve `versions.rs` and `images.rs`. This closes the chronic invariant-in-prose finding.
424	2. UX CRIT — Field-aware validation reaches the UI. `error.rs:216-264` + `templates/error.html` + `templates/partials/form_errors.html` (new). Either (a) add `fields: Vec<(String, String)>` to `ErrorTemplate` and a `{% for f in fields %}` block in `error.html` + per-input markup; or (b) delete `validation_fields*` API entirely and replace handler callsites with `validation(summary)`. Choose (a) for non-HTMX forms that need to preserve user input; choose (b) only if every existing callsite is HTMX-only and uses OOB swaps for inline errors. Audit all `validation_fields` callers and pick a path.
425	3. Perf CRIT — `build_runner.rs` partial-failure denominator. `build_runner.rs:175-180`. Track `failed_count` alongside `artifact_keys`; report `succeeded/(succeeded+failed)`. Add a test that runs 3 targets with 2 failures and asserts "1/3" in the error string.
426
427	## Phase 2 — SERIOUS / HIGH (fix this weekend)
428
429	4. Payments SERIOUS — NULL item_id refund decode. `db/transactions.rs:699-716`. Change return to `Vec<(TransactionId, Option<ItemId>)>`; `refund_transaction_by_payment_intent` caller skips `decrement_sales_count`/`revoke_keys_by_transaction` when `item_id is None`. Add a fixture-based test against a project-level transaction.
430	5. Payments SERIOUS — `compute_splits` over-credit. `routes/stripe/webhook/checkout_helpers.rs:240-269`. Reject `total_split_pct > 100` at the project_members write site (DB CHECK or validation). Defensively, scale each split proportionally when sum > 100, OR clamp each split against remaining `expected_total` budget in the loop. Add a test at 60%+60%.
431	6. Payments SERIOUS — Tip project authorization. `routes/stripe/checkout/tips.rs:104-106`. After accepting `TipForm`, fetch the project and assert `project.user_id == recipient_id`; return 400 otherwise.
432	7. Payments SERIOUS — Cart bypasses `listed` gate. `db/cart.rs:94-123` and `get_cart_items`/`get_cart_items_for_seller`. Add `AND i.listed = true` to all three queries. Add a check in the per-seller checkout path. Add a regression test that toggles an unlisted item into the cart and asserts rejection.
433	8. Payments SERIOUS — Unknown subscription status. `routes/stripe/webhook/subscriptions.rs:117-121`. Replace `?` with a match: known statuses dispatch; unknown statuses `tracing::warn!` and return `StatusCode::OK` so Stripe stops retrying.
434	9. Payments SERIOUS — `is_full_refund` zero-amount. `payments/webhooks.rs:294-308`. Predicate becomes `amount > 0 && amount_refunded >= amount`. Update the test at line 517-525 to invert (zero-amount must NOT be treated as full refund).
435	10. Storage HIGH — `versions.rs` enqueue-before-idempotency. `routes/storage/versions.rs:159-174`. Move idempotency `version.s3_key == req.s3_key` check BEFORE `enqueue_scan_for`. Apply the Phase 1 `commit_upload` helper here.
436	11. Storage HIGH — `project_image_confirm` probe-failure + no rollback. `routes/storage/images.rs:179-208`. (a) On `Err` or `Ok(None)` from `s3.object_size`, fall back to the row's recorded size (add a `project_image_bytes` column if not present) rather than the "no old image" branch. (b) Move `enqueue_deletions` to AFTER `update_project_image_url` success, or wrap both in a tx with the enqueue inside.
437	12. Storage HIGH — `media_confirm` non-atomic three-write. `routes/storage/media.rs:236-293`. Wrap `try_increment_storage` → `remove_pending_upload` → `media_files::create` in a transaction. The storage credit refund must fire on any failure path.
438	13. UX HIGH — Negative/NaN prices via `from_db`. `routes/pages/dashboard/wizards/item/save.rs:183-185, 214-227`. Use `PriceCents::new(price_cents)?` unconditionally; drop the `> 0` guard. Add `min <= suggested` check on PWYW.
439	14. UX HIGH — f64 price parsing accepts NaN. Same file + `routes/api/items/bulk.rs:136-139` + `routes/pages/dashboard/wizards/project.rs:264-298`. Parse as decimal cents directly (or `Decimal::from_str_exact` from the `rust_decimal` crate already in `Cargo.lock`); reject NaN/Inf; reject negative/saturating values before cast.
440	15. UX HIGH — Username live-check fails open. `routes/auth.rs:356-361`. Propagate the DB error or treat it as "unavailable, try again" — never "available" by default.
441	16. Perf HIGH — Cart checkout sequential roundtrips. `routes/stripe/checkout/cart.rs:68-248`. Bulk-load `has_purchased_item` once with `WHERE item_id = ANY($1)`. Batch `get_item_by_id` lookups. Claim free items in a single transaction with batched inserts. Aim for ≤ 5 roundtrips for any cart size.
442	17. Perf HIGH — `record_view` unbounded spawn. `db/page_views.rs:18-32`. Replace per-request spawn with an `mpsc` channel; one background task drains every 250ms and flushes one bulk `INSERT … ON CONFLICT … DO UPDATE SET view_count = page_view_daily.view_count + EXCLUDED.view_count`.
443	18. Perf HIGH — Sales drift full-table aggregate. `scheduler/integrity.rs:53-73`. Maintain trigger-updated `transactions_completed_count` per item, or run the check off-pool against a snapshot. Short term: add `WHERE i.sales_count > 0 OR EXISTS (SELECT 1 FROM transactions WHERE item_id = i.id LIMIT 1)` to drop the LEFT JOIN's all-zero rows from the aggregate.
444
445	## Phase 3 — MED (fix before re-run if cheap)
446
447	- Storage: advisory-lock leak in `check_sandbox_cap` (`db/mod.rs:92-128`) → `pg_advisory_xact_lock` or RAII guard.
448	- Storage: `is_s3_key_live` missing tables (`db/pending_s3_deletions.rs:67-82`) → audit all s3_key-bearing columns; consider normalized `s3_objects` table.
449	- Storage: `delete_version` owner SELECT outside tx + post-commit S3 enqueue (`db/versions.rs:267-315`) → owner SELECT inside tx; enqueue inside tx.
450	- Security: ClamAV `FailOpen` startup assertion (`scanning/clamav.rs:19` + `scanning/mod.rs:151-164`) → refuse boot if scan configured but no AV layer live; emit `tracing::error!` after N consecutive ClamAV errors.
451	- Security: `helpers.rs:44-50` `DefaultHasher` for advisory lock keys → stable hasher (`sha2` first 8 bytes, or `xxh3` with constant seed).
452	- Security: OAuth `state` size cap (`routes/oauth.rs:379-386`) → reject `form.state.len() > 1024`; cap `code_challenge` at 44 base64url chars.
453	- Security: `extract_client_ip` non-Cloudflare fallback warning (`helpers.rs:33-40`) → emit one-shot `tracing::warn!` at startup if no `CF-Connecting-IP` seen after N requests.
454	- UX: pagination offset overflow (`routes/pages/public/discover.rs:85-87`, `routes/admin/users.rs:37-39`) → clamp `page` to `total_pages.max(1)` before arithmetic.
455	- UX: forms render without `_csrf` when handler forgets to populate `csrf_token` → make `csrf_token` non-optional in form-bearing templates (compile-time error) or render an inline "refresh and try again" notice.
456	- UX: `validate_username` byte-length check (`routes/auth.rs:322`) → `chars().count()`, or reorder ASCII filter before length.
457	- Perf: scheduler advisory-lock connection pinned across S3 (`scheduler/mod.rs:92-279`) → dedicated `PgPoolOptions::new().max_connections(1)` outside the main pool.
458	- Perf: cleanup S3 deletes serialized inside scheduler tick (`scheduler/cleanup.rs:77-100`) → `for_each_concurrent(8, ...)`; better, move user-deletion off the scheduler tick.
459
460	## Phase 4 — Polish (after re-run shows axes ≥ A-)
461
462	- Payments: `has_active_subscription_to_item` period-end clause mirroring (`db/subscriptions.rs:464-470`).
463	- Payments: `get_active_creator_tier` + `sync_user_creator_tier` period-end defense (`db/creator_tiers.rs:91-103, 181-194`).
464	- Payments: `release_use_count` race messaging (`db/promo_codes.rs:184-200`).
465	- Payments: License key `activation_count` recount on revoke (`db/license_keys.rs:343-382`).
466	- Payments: Subscription minimum-charge check (`payments/checkout.rs:283-317`).
467	- Payments: Webhook v1/v2 unmark-on-failure parity (`routes/stripe/webhook/mod.rs:48-86`).
468	- Storage: `media_files.list_folders` scan filter (`db/media_files.rs:73-82`).
469	- Storage: `pending_uploads.record_pending_upload` silent user-mismatch (`db/pending_uploads.rs:23-33`).
470	- Storage: `append_log_bounded` non-atomic size cap (`build_runner.rs:516-534`).
471	- Storage: `downloads.rs:119-122` presigned-URL expiry: cap `duration_seconds` at i64 + add DB CHECK ≥ 0.
472	- Security: `validate_token_consuming` for OAuth POST (`routes/oauth.rs:206`).
473	- Security: `parse_repo_path` rejects lone-dot entries (`git_ssh.rs:162`).
474	- Security: ClamAV INSTREAM 16K cap → treat truncation as fail-closed (`scanning/clamav.rs:101-108`).
475	- UX: validation error messages stop reflecting user input (`wizards/item/mod.rs:176-179`).
476	- UX: CSRF body extraction stops using `from_utf8_lossy` (`csrf.rs:528-543`).
477	- Perf: scan-pipeline 400 MiB worst-case capacity-plan note (`constants.rs:156-157`).
478	- Perf: announcement fan-out persistence + resume (`scheduler/announcements.rs:59-89, 147-177`).
479	- Perf: build log per-line DB roundtrip (`build_runner.rs:516-534`) → in-process running total.
480
481	## Phase 5 — Chronic (must land in Run #6 or this audit cycle has failed)
482
483	Invariant-in-prose / policy-not-in-types, fourth consecutive run. The Phase 1 #1 fix (constructive `commit_upload` helper sealing the lower-level ops) is the only acceptable resolution. Memory notes, comments warning future authors, and renamed-helper approaches have been tried in three prior runs and recurred each time. After Phase 1 lands, audit `compute_splits` and `ErrorTemplate` for the same shape and apply the same treatment.
484
485	---
486
487
488
489	## Headline
490
491	\| Axis \| Run #3 \| Run #4 \| Direction \|
492	\|------\|--------\|--------\|-----------\|
493	\| Payments \| A- \| A- \| flat (1 new SERIOUS: promo over-release on cart cleanup) \|
494	\| Storage \| B+ \| A- \| ↑ (Run #3 image-confirm rollback/race-guard fixes verified; one residual CRIT in same file) \|
495	\| UX Wiring \| B+ \| C+ \| ↓ (CSRF policy patchwork: missing tokens + undocumented mutation in exempt prefix) \|
496	\| Security \| B+ \| B+ \| flat (different HIGHs: git-shell repo-name validation + lockout DoS) \|
497	\| Performance \| B- \| B \| ↑ (Run #3 sync-FS-in-async + DashMap shard-lock + monitor split all verified; new unbounded scan_jobs/broadcast/pool-permit findings) \|
498
499	Net: 4 CRITICALs (vs Run #3: 2), 10 HIGH/SERIOUS (vs Run #3: 10), 22 MED, 23 MINOR/LOW. Ship-blockers are concentrated in two structural rots — CSRF policy and scan_jobs growth — not in net-new logic mistakes.
500
501	## Critical / High Findings (fix before launch)
502
503	1. [UX — CRITICAL] `templates/partials/tabs/user_creator.html:80,85` — Creator-tier subscribe forms have only `tier`+`interval` hidden inputs. `/stripe/creator-tier` is not in the CSRF exempt list (`csrf.rs:166-174`). Authenticated users hitting "Monthly" or "Annual" get 403.
504	2. [Storage — CRITICAL] `routes/storage/images.rs:457-466` — `item_image_confirm` writes `scan_status` BEFORE the row UPDATE at line 508. The Run #3 fix to `uploads.rs:249-265` and `versions.rs:159-175` added a multi-line comment in each file explicitly forbidding this ordering, but `images.rs` was not updated. A lost-race rollback now flips a Clean cover back to Pending → invisible until rescan.
505	3. [Security — HIGH] `git_ssh.rs:90-102` + `db/git_repos.rs:21-35` — On first push, `parse_repo_path` only rejects `..`/leading-slash/null bytes/empty. `validate_git_repo_name` (the strict `[A-Za-z0-9._-]` allow-list) is not called before lookup or `create_repo` INSERT, and the raw name flows into `format!("{op} '/{owner}/{repo_name}.git'")` fed to `git-shell -c`. `cmd_ssh_repo_delete` validates (line 354); the dispatch path does not.
506	4. [Security — HIGH] `db/auth.rs:30-54` — `RETURNING (failed_login_attempts >= $2) AS just_locked` fires `true` on EVERY post-threshold attempt. `routes/auth.rs:161-182` mints + emails a fresh one-time login token each time. An attacker who knows a victim's email can flood their inbox.
507	5. [UX — HIGH] `routes/stripe/checkout/item.rs:390-407` — `cancel_pending_item_checkout` deletes the `pending_item_purchases` row and releases promo `use_count` BEFORE any Stripe call. It sits in the `/stripe/checkout` CSRF-exempt prefix whose documented invariant is "no state mutation occurs until Stripe's webhook confirms payment". SameSite=Lax is the only protection.
508	6. [Payments — SERIOUS] `scheduler/cleanup.rs:223` + `db/transactions.rs:1011-1029` — `cleanup_stale_pending` returns one row per deleted tx; cart checkouts produce N rows (one per cart line) carrying the SAME `promo_code_id`. The release loop calls `release_use_count` N times for a single reservation. `GREATEST(0,…)` clamp prevents negatives but lets the code be reused beyond `max_uses` when other users have legitimately incremented.
509	7. [Storage — SERIOUS] `storage.rs:179,404,629` + `scanning/worker.rs:175` — `download_object` returns `Vec<u8>`. `MAX_MEDIA_VIDEO_SIZE = 20 GB`. A single quarantine scan of a 20 GB upload OOMs the worker; multiple concurrent scans amplify. Trait has no streaming variant.
510	8. [Perf — CRITICAL] `db/scan_jobs.rs` — No pruning of completed/failed scan_jobs rows; table grows unbounded since launch.
511	9. [Perf — CRITICAL] Scanner DB pool permit held across S3 download (`scanning/worker.rs`); under any scan backlog the pool starves request traffic.
512	10. [Perf — HIGH] `routes/api/users/broadcast.rs` — unbounded sequential loop over subscribers; one broadcast can pin a worker for minutes.
513
514	## Scorecard
515
516	### Axis Summary Grades
517
518	\| Axis \| Overall \| Cold Spots \| Mandatory Surprise \|
519	\|------\|---------\|------------\|--------------------\|
520	\| Payments \| A- \| `routes/stripe/checkout/cart.rs::process_seller_checkout` neighborhood (B+), `routes/stripe/checkout/item.rs::cancel_pending` (B+) \| `process_webhook_event` in `webhook/mod.rs` is shared verbatim between live HTTP handler and the scheduler retry worker; dispatcher takes pre-parsed event so replays survive Stripe secret rotation. Comment at line 108-110 calls this out explicitly. Most mature piece of payment plumbing in the audit. \|
521	\| Storage \| A- \| `routes/storage/images.rs` (B-) \| Comments in `uploads.rs` and `versions.rs` explicitly warn against the scan_status ordering bug — and reference the audit run number that caught it — yet the third handler reintroduced the exact bug. The invariant lives in prose, not types; the fix should be a shared `commit_upload_and_flip_scan_status(...)` helper so wrong ordering is uncompilable. \|
522	\| UX Wiring \| C+ \| `routes/stripe/*` family (C+), cart templates (B+), `formatting.rs` (B+) \| The `/stripe/checkout` exempt prefix has rotted into THREE incompatible models: middleware-validated, handler-validated (tip handler — documented), and silently-unvalidated-but-mutating (`cancel_pending_item_checkout` — undocumented). \|
523	\| Security \| B+ \| `git_ssh.rs` (B-), `db/auth.rs` (B), `db/totp.rs` (B+), `db/sessions.rs` (B+) \| The TOTP `pending_2fa_*` session state writes have no tracking-row entry; `delete_all_sessions_for_user` cannot sweep a phisher mid-2FA-prompt session. Intermediate authenticated state without tracking is invisible to "log out everywhere". \|
524	\| Performance \| B \| `db/scan_jobs.rs` (B-), `scanning/worker.rs` (B-), `routes/api/users/broadcast.rs` (C+), `scheduler/completion_effects.rs` (B), `scheduler/integrity.rs` (B+) \| `KNOWN_SYNC_APPS` has only insertions, no removals — deleted sync apps leak rate-limit buckets forever. The very bucket-explosion the defense was written to prevent, just on the deletion side instead of the forgery side. \|
525
526	### Module Heatmap (B or below, by axis)
527
528	\| Module \| Axis \| Grade \| Reason \|
529	\|--------\|------\|-------\|--------\|
530	\| `routes/storage/images.rs` \| Storage \| B- \| CRIT #2: scan_status flip before row UPDATE; comment warning ignored \|
531	\| `routes/stripe/*` family \| UX \| C+ \| CRIT #1 (missing token) + HIGH #5 (silent mutation in exempt prefix); B- cap from CRIT, dragged to C+ by HIGH #5 \|
532	\| `git_ssh.rs` \| Security \| B- \| HIGH #3: repo name unvalidated through to `git-shell -c` \|
533	\| `db/auth.rs` (login lockout) \| Security \| B \| HIGH #4: `just_locked` fires every post-threshold attempt → email flood \|
534	\| `db/scan_jobs.rs` \| Perf \| B- \| CRIT #8: no prune; table grows unbounded \|
535	\| `scanning/worker.rs` \| Perf \| B- \| CRIT #9: DB pool permit held across S3 download; SERIOUS #7: 20 GB Vec<u8> \|
536	\| `routes/api/users/broadcast.rs` \| Perf \| C+ \| HIGH #10: unbounded sequential loop \|
537	\| `scheduler/completion_effects.rs` \| Perf \| B \| Serial fan-out \|
538	\| `scheduler/integrity.rs` \| Perf \| B+ \| Sales drift full scan \|
539	\| Cart templates \| UX \| B+ \| Business logic / price math in template; thousand-sep divergence with `format_revenue` \|
540	\| `formatting.rs` \| UX \| B+ \| `format_price` thousands-sep ≠ `format_revenue` (no separators); side-by-side dashboards render inconsistently \|
541	\| `db/totp.rs` \| Security \| B+ \| `totp_last_used_step` not cleared on disable/re-enable \|
542	\| `db/sessions.rs::delete_other_sessions` \| Security \| B+ \| No `RETURNING id`; in-memory `session_cache` not evicted \|
543	\| `db/builds.rs::claim_pending_build` \| Storage \| B+ \| NOT EXISTS race; dormant on single replica, breaks on second \|
544	\| `routes/storage/media.rs` \| Storage \| B+ \| M5: delete-then-reupload races worker (no entity recheck before S3 delete) \|
545	\| `csrf.rs` \| UX \| A- \| `/login` exempt without compensating manual `validate_token` (handler does not check `_csrf`) \|
546
547	## Bug Counts by Severity
548
549	\| Severity \| Payments \| Storage \| UX \| Security \| Perf \| Total \|
550	\|---\|---\|---\|---\|---\|---\|---\|
551	\| CRITICAL \| — \| 1 \| 1 \| — \| 2 \| 4 \|
552	\| HIGH/SERIOUS \| 1 \| 2 \| 1 \| 3 \| 3 \| 10 \|
553	\| MED \| 4 \| 5 \| 4 \| 4 \| 5 \| 22 \|
554	\| MINOR/LOW \| 3 \| 5 \| 6 \| 5 \| 4 \| 23 \|
555
556	## Cross-Cutting Concerns
557
558	1. CSRF policy has rotted into a patchwork. Three flavors of `/stripe/*` coexist: exempt-and-middleware-validated, exempt-and-handler-validated, exempt-and-unvalidated-but-mutating. One model — preferably "always-enforced + per-route opt-out macro at handler" — would have caught CRIT #1 + HIGH #5 at review time. (Same disease as Run #3's extractor-policy gap, different organ.)
559	2. Invariants live in prose, not types. The scan_status-ordering bug (CRIT #2) was documented in comments in two sibling handlers explicitly referencing prior audit runs, yet reintroduced in a third. Same pattern as Run #3's `MaybeUser` extractor sprawl: needs a constructor / helper that makes the wrong ordering uncompilable.
560	3. Unbounded background tables / sets. `scan_jobs` (CRIT #8), `KNOWN_SYNC_APPS` (Performance mandatory surprise), `pending_2fa_*` session state (Security mandatory surprise). Three independent grow-forever surfaces; each has the same shape (insert-only, no GC).
561	4. Multi-replica latent bugs. `claim_pending_build` NOT EXISTS race, `populate_known_sync_apps` startup-only, status-notification fan-out lacks cross-task cooldown. Production is single-instance; the day a second appears, three things break in non-obvious ways simultaneously.
562	5. Resource-lifecycle gaps on partial-failure paths. Media delete-then-reupload (M5), `pending_uploads` reaper bump (S4), `pending_s3_deletions` worker without entity recheck. Worker queues lack "is this entity still gone?" predicates.
563
564	## Components Successfully Stress-Tested
565
566	- Stripe HMAC verification: `subtle` constant-time, multi-secret, bidirectional clock skew, distinct error strings.
567	- Webhook dedup + retry-queue inside completion tx (Run #3 fix verified). Shared `process_webhook_event` between live + retry paths bypasses re-verify across rotation.
568	- `charge.refunded` over-refund detection → operator-alert path.
569	- Refund-before-charge: `pending_refunds` `FOR UPDATE SKIP LOCKED` + escalation flag.
570	- Promo `apply_discount` — proptest + 25 adversarial tests including negative discount, over-100% clamp, integer rounding.
571	- License keys: 66-bit entropy + DB UNIQUE + `FOR UPDATE` activation lock + full recount.
572	- Stripe Connect race: atomic claim + orphan-cleanup log.
573	- 4-tier scheduler decomposition (Run #2 fix verified): advisory-locked per tier.
574	- Monitor decomposition into 3 cadences (Run #3 fix verified).
575	- `try_increment_storage` cap-predicate UPDATE — concurrent uploads cannot both squeeze past the cap.
576	- `pending_s3_deletions` `FOR UPDATE SKIP LOCKED` + dead-letter (Run #3 fix verified).
577	- `delete_objects`: chunked at 1000, JoinSet-bounded 4-way.
578	- S3 multipart streams from disk in `build_runner` (Run #3 fix verified).
579	- Argon2id 46MiB/2it + `DUMMY_HASH` timing equalization on user-not-found.
580	- PKCE-S256-only at both endpoints + atomic OAuth-code consume.
581	- JWT future-iat rejection (60s skew) + `jwt_invalidated_at` second-equal rejection (Run #3 fix verified).
582	- Session fixation: `cycle_id` on login + `flush` on logout + fresh CSRF cycled with session ID.
583	- ZIP bomb: decompressed-bytes (not claimed) tracked, ratio + depth caps, encoded-traversal, nested magic-byte detection beats extension renames.
584	- YARA 30s scan timeout; ClamAV circuit breaker (10 errors → flip clean→held).
585	- Rate-limit bucket-explosion defense (forged JWT app IDs collapse to nil).
586	- IP extractor: `CF-Connecting-IP` only; never XFF.
587	- CSRF middleware: `url::form_urlencoded` parsing (textarea-smuggling defense); multipart rejected with audit log; 2 MiB body cap.
588	- `json_escape` blocks JSON-LD script-tag injection.
589	- Slugify + CSV-injection prefix safeguards (`=`, `+`, `-`, `@`, tab, CR + ZWS variants).
590	- `validate_link_url`: `javascript:`/`data:` rejected.
591	- SSE shard-guard drop-before-remove pattern (Run #3 fix verified); same care now applied to push side.
592	- Discover pagination clamp (Run #3 fix verified).
593	- `is_localhost_redirect` via `url::Url::parse` (Run #3 fix verified).
594
595	## Confidence Per Axis
596
597	- Payments HIGH — webhook chain read end-to-end; S1 reproducible by line-tracing.
598	- Storage HIGH — CRIT #2 mechanically reproducible; mandatory surprise documents the exact prior-run audit footprint.
599	- UX HIGH for CSRF findings (#1, #2 — er, #5); MEDIUM for markdown XSS surface (docengine sanitization not audited).
600	- Security MEDIUM-HIGH — git-shell exploit needs empirical confirmation against the parser; gap is real either way. TOTP `pending_2fa_*` finding inferred from auth.rs:194-210; 2FA-finish handler not read.
601	- Performance MEDIUM-HIGH — broad routes coverage; admin/items routes sampled, not exhaustive. Schema not opened; some index claims inferential.
602
603	## Metrics
604
605	- Modules audited: ~75
606	- Cold spots (≤ B): 16
607	- Bugs: 4 CRITICAL, 10 HIGH/SERIOUS, 22 MED, 23 MINOR/LOW
608	- Axes at A- or above: 2/5 (Payments, Storage)
609
610	## Delta Since Run #3
611
612	FIXED (Run #3 items not surfaced this run):
613	- Run #3 CRIT `images.rs` no-rollback / no-race-guard ×2 — partial fix landed: race-guard backported, rollback for storage credit + S3 orphan landed. Residual: the scan_status ordering inside the same fix was missed (becomes Run #4 CRIT #2).
614	- Run #3 HIGH `MaybeUserVerified` suspension not enforced — fix verified in `auth.rs` extractors; security agent did not re-flag.
615	- Run #3 HIGH JWT iat second-resolution race — fix verified in `synckit_auth.rs` (`<=` comparison).
616	- Run #3 HIGH sync FS / `reqwest::Client::new()` in dashboard/exports/`create_repo` — fix verified; performance agent did not re-flag.
617	- Run #3 HIGH DashMap shard-lock across SSE push — fix verified at `routes/synckit/sync.rs:104`.
618	- Run #3 HIGH monitor task overload — fix verified (3 cadences in `monitor.rs:112-117`).
619	- Run #3 SERIOUS cart drift validation parity — fix verified (`validate_cart_against_live_items` extracted; both paths call it).
620	- Run #3 SERIOUS scan_status flip ordering in `uploads.rs` + `versions.rs` — fix verified; comments documenting the fix are now part of the surface area of Run #4 CRIT #2 (the bug they warn against was reintroduced in `images.rs`).
621	- Run #3 SERIOUS media double-decrement race — fix verified (`RETURNING *` + `is_some()` gate).
622
623	CHRONIC (across Run #3 → Run #4):
624	- Invariant-in-prose / policy-not-in-types. Run #2→#3 was MaybeUser extractor sprawl. Run #3→#4 is scan_status ordering comment-vs-code drift AND CSRF policy patchwork. Different organ; same disease. Structurally unfixed for 3 consecutive runs.
625
626	REGRESSED:
627	- UX Wiring (B+ → C+) — CRIT #1 (missing CSRF on creator-tier forms) + HIGH #5 (silent mutation in CSRF-exempt prefix) + cart template math.
628
629	NEW HIGHs/CRITs in Run #4:
630	- Missing CSRF token on creator-tier forms (CRIT).
631	- `cancel_pending_item_checkout` mutation in CSRF-exempt prefix (HIGH).
632	- `git_ssh.rs` repo-name unvalidated to `git-shell -c` (HIGH).
633	- Login lockout `just_locked` per-attempt email/token flood (HIGH).
634	- Promo `use_count` over-release on cart cleanup loop (SERIOUS).
635	- Scanner `Vec<u8>` RAM blowup on 20 GB media (SERIOUS).
636	- `scan_jobs` unbounded growth (CRIT).
637	- Scanner DB-pool permit held across S3 download (CRIT).
638	- `broadcast.rs` unbounded sequential loop (HIGH).
639
640	---
641
642	# Plan: Restore Every Axis to A- or Higher
643
644	Target grades: Payments A · Storage A · UX A- · Security A- · Performance A-.
645
646	## Phase 1 — Clear HIGH/CRITICAL caps (must do before launch)
647
648	1. CSRF token on creator-tier forms (CRIT #1). Add `{% if let Some(token) = csrf_token %}<input type="hidden" name="_csrf" value="{{ token }}">{% endif %}` to both forms in `templates/partials/tabs/user_creator.html:80,85`. Verify the handler context populates `csrf_token`.
649	2. `images.rs` scan_status ordering (CRIT #2). Move `update_item_scan_status` to AFTER the `Ok(true)` arm at `images.rs:519` — matching the documented ordering in `uploads.rs:249-265` and `versions.rs:159-175`. Land a shared helper (e.g. `commit_upload_and_flip_scan_status(...)`) so future handlers cannot get the ordering wrong.
650	3. `git_ssh.rs` repo name validation (HIGH #3). Call `validate_git_repo_name(repo_name).map_err(\|_\| anyhow!("repository not found"))?` immediately after `parse_repo_path` succeeds in the dispatch path. Add the same check in `db::git_repos::create_repo`. Match the discipline `cmd_ssh_repo_delete` already has at line 354.
651	4. Login lockout `just_locked` (HIGH #4). Change `db/auth.rs:30-54` `RETURNING` clause to `(failed_login_attempts = $2) AS just_locked` (exact equality on the crossing attempt). Follow-up: cap the lockout-email rate independently via an idempotency key on `email_outbox`.
652	5. `cancel_pending_item_checkout` CSRF gap (HIGH #5). Either narrow the `/stripe/checkout` exempt prefix so this path isn't in it, OR add explicit `csrf::validate_token` like `create_tip_checkout` does. Document the rule at the prefix definition site so the next "I'll just add a quick mutation handler" landing fails review.
653	6. Promo `use_count` over-release on cart cleanup (SERIOUS #6). Dedupe `promo_ids` in `cleanup_stale_pending_transactions` (`HashSet<PromoCodeId>` before the release loop) OR have `cleanup_stale_pending` SQL return `DISTINCT promo_code_id`.
654	7. Scanner `Vec<u8>` → stream (SERIOUS #7). Add `download_stream`/`get_object_stream` to the S3 trait returning a `ByteStream`. Wire the scanner worker to pipe through ClamAV instead of buffering 20 GB into memory.
655	8. `scan_jobs` retention (CRIT #8). Add a scheduler tier (hourly) that deletes `scan_jobs` rows older than N days where status ∈ {Clean, Quarantined, Failed}. Keep Pending/Running. Document N (default 30 days) in `constants.rs`.
656	9. Scanner DB-pool permit (CRIT #9). Drop the pool permit before the `download_object` await; reacquire after the bytes are local. Or move the S3 fetch outside the DB-bounded code path entirely.
657	10. `broadcast.rs` unbounded loop (HIGH #10). Move broadcast send into `tokio::spawn` with a bounded `JoinSet` (cap 16) over recipient chunks; per-recipient send already has 100ms shape — keep it.
658
659	## Phase 2 — Close axis-dragging SERIOUS items
660
661	11. Cart template price math. Move price-formatting out of templates; either pass pre-formatted strings from the handler or expose `format_price` as an Askama filter. Unify with `format_revenue` (thousands sep).
662	12. `media.rs` delete-then-reupload race (Storage M5). Worker re-checks `SELECT 1 FROM media_files/items/versions WHERE s3_key = $1` before each S3 delete. OR queue inserts carry the entity-ID and the worker confirms absence.
663	13. `pending_uploads` reaper bump (Storage S4). ON CONFLICT only refresh `created_at` when `user_id` matches; otherwise treat as fresh row.
664	14. TOTP step-replay across re-enable (Security MED). `disable_totp` clears `totp_last_used_step` (NULL); `set_totp_secret` resets to 0 / NULL.
665	15. `delete_other_sessions` cache eviction (Security MED). Return `RETURNING id` so callers can evict `state.session_cache`.
666	16. CSRF on `/login` (Security MED). Move `/login` out of `exempt_prefixes` and have `login_handler` call `csrf::validate_token` like `authorize_post` does. The login template already renders the token.
667	17. `is_registered_redirect_uri` `fetch_one`→`fetch_optional` (Security MED). Return `Ok(false)` on `None`; document trailing-slash matching policy.
668
669	## Phase 3 — Resilience & infra hardening
670
671	18. Multi-replica `claim_pending_build`. Add `CREATE UNIQUE INDEX … ON ota_builds(status) WHERE status='running'` partial unique index, OR explicit `pg_advisory_xact_lock` around claim.
672	19. Build status race with stale reaper (Storage M4). Add `WHERE status='running'` to the success UPDATE and check `rows_affected`.
673	20. `KNOWN_SYNC_APPS` deletion path. Add `unregister_known_sync_app` called from sync-app delete. Long-term: switch from `OnceLock<DashSet>` to a DB-backed cache with TTL so multi-replica deploys don't diverge.
674	21. `extract_s3_key_from_url` host pinning (Storage S3). Require the `https://` host to be the configured S3 endpoint or a known CDN domain.
675	22. *TOTP `pending_2fa_` tracking row (Security surprise).** Insert a temporary tracking row at the moment 2FA-pending begins, scoped via `kind='pending_2fa'` so `delete_all_sessions_for_user` can sweep it.
676
677	## Phase 4 — Polish
678
679	23. `MaybeUserUnverified` rename. Rename to make the danger boundary impossible to forget at use site (e.g. `SessionUserStaleAllowed`), or short-circuit to `None` when the session lacks `SESSION_TRACKING_KEY`.
680	24. `sum_file_sizes_for_item` clamp direction (Storage M6). `GREATEST(0, LEAST(SUM, i64::MAX))::BIGINT`.
681	25. License key collision retry (Payments M3). Retry once on 23505 in `create_license_key` and the promo-claim arm.
682	26. Stripe v1-rotation header (Payments M1). Collect all `v1=` values; accept on any match.
683	27. `has_active_subscription_to_project` period-end check (Payments M2). `AND (current_period_end IS NULL OR current_period_end > NOW())`.
684	28. HTML sniff strengthening (Security MED). For Download type, add a string sniff for `<!--`, `<script`, `<svg`, `<?xml`, BOM-stripped `<html` after `infer` returns None. Pair with `Content-Disposition: attachment` on all served downloads.
685	29. `rel="ugc nofollow"` on profile links (UX LOW).
686
687	## Phase 5 — Chronic
688
689	30. Invariant-in-prose, third run unfixed. Pull the scan_status-ordering comment-block in `uploads.rs` and `versions.rs` into a shared helper. Pull the CSRF policy decision into a per-route macro at handler definition. Both are the same disease as Run #3's extractor-policy gap. If this is not addressed structurally by Run #5, escalate to a dedicated session.
690
691	## Expected post-plan grades
692
693	\| Axis \| After P1 \| After P2 \| After P3 \| Final \|
694	\|------\|---\|---\|---\|---\|
695	\| Payments \| A \| A \| A \| A \|
696	\| Storage \| A- \| A \| A \| A \|
697	\| UX Wiring \| B+ \| A- \| A- \| A- \|
698	\| Security \| A- \| A- \| A- \| A- \|
699	\| Performance \| B+ \| A- \| A- \| A- \|
700
701	---
702
703	# Creator Trust Audit — 2026-05-31
704
705	Run: 2026-05-31, ahead of 2026-06-01 launch. Method: six parallel probes (money, ownership/portability, security/privacy, moderation/legal, reliability, vaporware/doc honesty) reading `site-docs/public/` and cross-checking against `src/`, `migrations/`, `deploy/`.
706
707	## Overall trust grade: B+
708
709	The honesty floor is unusually high — the docs admit limits competitors hide. The real problems are mostly disclosure gaps where code does something docs don't mention, not vaporware. Two deal breakers, ten trust gaps. None of the deal breakers require code changes for launch closure — both can be closed with doc edits.
710
711	## Deal breakers
712
713	### CT-DB-1. Fan+ credits funded from creator payout — undisclosed
714	- `src/db/promo_codes.rs:400-454` and `src/routes/stripe/checkout/cart.rs:146`: platform-wide promo codes (the path Fan+ monthly credits use) apply as discounts on the creator line item on the connected account. The creator's payout is reduced by the discount; MNW does not refund. No doc discloses this.
715	- Pre-launch close: add one paragraph to `guide/fan-plus.md` and the Fan+ enablement surface on the creator dashboard. Disclosure-only; no code change required.
716
717	### CT-DB-2. DMCA counter-notice flow is paper-only
718	- `legal/copyright.md:58-89` documents the full counter-notice process and a 3-strike repeat-infringer policy. No `dmca`/`takedown`/`counter_notice` code in `src/`; no strike counter in any migration.
719	- Pre-launch close: trim `legal/copyright.md:58-99` to "handled manually via info@makenot.work within the statutory window" until the in-app flow exists. Full implementation deferred post-launch.
720
721	## Trust gaps
722
723	\| ID \| Gap \| Where \| Close-at-launch plan \|
724	\|----\|-----\|-------\|----------------------\|
725	\| CT-TG-1 \| Instant-payout fee contradicts itself: guides say flat 1%, legal page says 1%/1.5% by region (legal is correct). \| `guide/payouts.md:18`, `guide/stripe.md:48,124` vs `legal/payments.md:49` \| Update two guide pages to match legal. \|
726	\| CT-TG-2 \| Splits are IOUs; no platform enforcement, no escrow, no recourse — not quantified in docs. \| `guide/splits.md:24-28`, `src/db/project_members.rs` \| Add a "What if the owner doesn't pay out?" paragraph. \|
727	\| CT-TG-3 \| `users.totp_secret` stored plaintext. DB dump yields working 2FA seeds. \| `migrations/001_initial_schema.sql:52`; `tech/security.md:42-50` admits no app-layer at-rest encryption broadly but doesn't single out 2FA seeds. \| Add one sentence to `tech/security.md` breach-scenario list. App-level encryption deferred. \|
728	\| CT-TG-4 \| `suspend_user` has no precondition; admin can suspend without prior warning despite `legal/moderation.md:50` implying a warning ladder. \| `src/db/users.rs:427`, `src/routes/admin/users.rs:143-197` \| Reword `moderation.md:50` to clarify the ladder is policy, not guarantee. Code enforcement deferred. \|
729	\| CT-TG-5 \| "Once per decision" appeal cap unenforced — `resolve_appeal` clears prior decision with no counter. \| `legal/appeals.md:95`, `src/db/users.rs:503-545` \| Drop "once" language from appeals.md, or add `appeal_count` column. Pick whichever ships faster. \|
730	\| CT-TG-6 \| Item-level removal appeals described but not implemented; appeal columns only on `users`. \| `legal/appeals.md:13`, `legal/moderation.md:69` \| Scope docs to user-level appeals only. \|
731	\| CT-TG-7 \| Submitted login identifiers (email or username) appear in error logs for unknown-account attempts; not disclosed in privacy policy. \| `src/routes/auth.rs:161` \| Either scrub the field or add one sentence to `legal/privacy-policy.md` logging section. \|
732	\| CT-TG-8 \| `legal/transparency.md` promises quarterly stats including subpoenas, government requests, DMCA notices — no schema to record them. \| `legal/transparency.md`, migrations \| Add empty `legal_requests` table now so launch-onward data exists, or trim columns. \|
733	\| CT-TG-9 \| MNW export → MNW import does not round-trip (importer is CSV-only). \| `src/routes/api/exports/mod.rs` vs `guide/import.md:68` \| Label JSON export as "for archive and third-party migration." \|
734	\| CT-TG-10 \| `tech/architecture.md:46` claims horizontal scaling behind a load balancer; `tech/infrastructure.md:87` says single-server, LB planned. \| architecture.md vs infrastructure.md \| Bring architecture.md in line with infrastructure reality. \|
735	\| CT-TG-11 \| Docs say "dynamic clips," DB/API says `content_insertions`. Terminology drift. \| `guide/dynamic-clips.md` vs `src/db/content_insertions.rs` \| Low priority; defer. \|
736
737	## Missing information
738
739	- No central limitations page. Caveats are scattered across feature docs. Consider one `about/limitations.md` indexing every known limit (storage caps, sandbox restrictions, splits-as-IOU, manual DMCA, item-appeal scope).
740	- No status page / incident RSS. Only `/health` + changelog blog. Creators relying on MNW for income need a one-click subscribe for outages.
741	- No restore-rehearsal evidence. Backups exist (`deploy/backup-db.sh`, `sync-backup-offsite.sh`, `sync-wal-offsite.sh`); no committed script restores them on a fresh host.
742
743	## Strengths (verified, not just claimed)
744
745	- 0% platform fee real. `src/payments/mod.rs:5`, `src/payments/checkout.rs:4`, all 5 `platform_fee_cents` insertion sites write `Cents::ZERO`. Direct Charges model; MNW never holds creator funds.
746	- ToS IP grant narrow. "License to host, display, distribute" only (`terms-of-service.md:30`). Narrower than Patreon/Substack/Gumroad.
747	- Account deletion does what it says. `src/routes/api/users/profile.rs:187` + `src/scheduler/cleanup.rs:147-203` wipe S3, git repos, CASCADE the row, 90-day buyer-notification grace for sellers.
748	- Argon2id password hashing with HIBP k-anonymity check, timing-attack dummy verify, 128-char DoS cap. Above industry norm.
749	- No indemnification clause from creators, no arbitration/class-action waiver. Creator-friendly.
750	- Bus factor disclosed. `support/faq.md:161` "A real risk." Not hidden.
751	- Roadmap honesty. `about/roadmap.md:6` explicitly disclaims commitment; planned features labeled.
752	- No vaporware. 16 high-priority features spot-checked (analytics, bundles, collections, custom domains, dynamic clips, embeds, mailing lists, promo codes, RSS, splits, sandbox, tips, wishlist, OAuth, license keys, OTA, SyncKit) — every one has route handlers and DB modules.
753
754	## Closure plan for launch (2026-06-01)
755
756	Closed pre-launch 2026-05-31 (doc-only edits):
757	1. CT-DB-1 — CLOSED. `guide/fan-plus.md` "For Creators" section now has a "How Fan+ credits interact with your payouts" subsection explaining that credits apply as line-item discounts on the creator's connected account and the creator absorbs the discounted portion.
758	2. CT-DB-2 — CLOSED. `legal/copyright.md` now opens the DMCA section with "Handled by email, not in-app" — full process described but framed as agent-handled, with in-app tooling labeled roadmap.
759	3. CT-TG-1 — CLOSED. `guide/payouts.md:16` and `guide/stripe.md:48,124` now state instant-payout fee as 1% / 1.5% by region, matching `legal/payments.md:49`.
760	4. CT-TG-3 — CLOSED. `tech/security.md` "At Rest" now includes a breach-scenario paragraph naming TOTP seeds explicitly and describing the planned app-level encryption.
761	5. CT-TG-10 — CLOSED. `tech/architecture.md` design principle rewritten to "Horizontal scaling ready, single-server today" with cross-link to `infrastructure.md`.
762	6. CT-TG-2 — CLOSED. `guide/splits.md` now has a "What this means if you're a collaborator" paragraph explicitly framing splits as IOUs with no platform enforcement.
763
764	Deferred with rationale (post-launch):
765	7. CT-TG-4 — Suspend-warning code enforcement: requires reworking admin flow + warning ledger; reword docs only for now.
766	8. CT-TG-5, CT-TG-6 — Appeals counter and item-appeal scope: docs trim is in-scope; code work is post-launch.
767	9. CT-TG-7 — Privacy policy login-string disclosure goes in this round; log scrub deferred.
768	10. CT-TG-8 — Transparency-report schema: first report not due at launch; defer.
769	11. CT-TG-9 — Round-trip import: doc relabel in-scope; import code deferred.
770	12. CT-TG-11 — Terminology drift: defer.
771	13. Restore-rehearsal script: should exist before launch; track as a separate launchplan item.
772
773	A finding is closed only when code/docs changed or a deferral is written above. Memory notes do not count as closure.
774
775	---
776
777	# Usability Audit — 2026-05-31
778
779	Run: 2026-05-31. Scope: public + creator surface. Method: four parallel probes (complexity, completeness, learnability, discoverability).
780
781	## Overall usability grade: B-
782
783	The surface is feature-rich and the code is honest, but several creator-facing features exist with no UI entry point and developer terminology (slug, dot-notation tags, "Publish at UTC") leaks throughout. New users land on a tabbed admin-style dashboard with no orientation. Power-user affordances (bulk ops, undo, resumable uploads) are mostly absent.
784
785	\| Dimension \| Grade \|
786	\|-----------\|-------\|
787	\| Complexity \| B- \|
788	\| Feature Completeness \| B \|
789	\| Learnability \| C+ \|
790	\| Discoverability \| C \|
791
792	## Critical friction (BLOCKER) — features dark or workflows dead-end
793
794	\| ID \| Issue \| Where \| Plan \|
795	\|----\|-------\|-------\|------\|
796	\| UF-B1 \| Corrected after verification: wishlists render inside the Collections tab (`library_collections.html:75-110`) and subscriptions render inside the Purchases tab (`library_purchases.html:86-104`). They are reachable but the tab labels do not advertise the nested content. `templates/partials/tabs/library_wishlists.html` and `library_subscriptions.html` are orphan files — no route, no template-struct, no `{% include %}`. \| `templates/partials/tabs/library_wishlists.html`, `library_subscriptions.html` \| Pre-launch: delete the orphan partials. Defer: consider a tab rename ("Purchases & Memberships") or surfacing the wishlist count next to "Collections". \|
797	\| UF-B2 \| Dynamic Clips / Insertions feature has zero entry point. Partials, routes, and DB all exist; no template includes them. Storage breakdown labels them "Clips" but nothing links there. \| `src/routes/api/content_insertions.rs`, `partials/insertion_list.html` \| Defer: needs a real Clips panel in `user_creator.html` or `item_files.html`. Disable feature flag or hide the storage-breakdown row until UI lands. \|
798	\| UF-B3 \| Mailing Lists code exists; no creator UI exists to view subscribers or broadcast. \| `src/db/mailing_lists.rs` \| Defer: add to post-launch. Pre-launch: remove any doc references that imply self-serve. \|
799	\| UF-B4 \| OTA Releases has routes but no UI inside the SyncKit tab. \| `src/routes/ota.rs`, `templates/partials/tabs/user_synckit.html` \| Defer; developer surface. Pre-launch: document the API in `developer/ota.md` if not already. \|
800	\| UF-B5 \| Buyer cannot request a refund anywhere in the app — only the creator-side refund endpoint exists. \| `templates/pages/receipt.html`, `library_purchases.html` \| Pre-launch: add a "Contact creator about this purchase" mailto link on the receipt and library row. Self-serve refund flow deferred. \|
801	\| UF-B6 \| Creator broadcast only emails followers, not buyers of a specific item. \| `src/routes/api/users/broadcast.rs` \| Defer: implement per-item recipient set post-launch. Pre-launch: document the limitation in `guide/mailing-lists.md` or wherever broadcast is described. \|
802	\| UF-B7 \| Item listing capped at 500 with no pagination UI; transactions capped at 100. \| `src/db/items/mod.rs:171`, `src/constants.rs:43` \| Defer: post-launch real pagination. Acceptable at alpha scale. \|
803	\| UF-B8 \| No resumable uploads. A drop on a 2GB upload restarts from zero. \| `static/upload.js:35` \| Defer: significant work (tus or multipart). High-impact post-launch item. Pre-launch: surface the limitation in `guide/files.md`. \|
804	\| UF-B9 \| Cart dead-ends when a creator has no Stripe connected — no path to remove that creator's items in bulk or to notify them. \| `templates/pages/cart.html:122-126` \| Pre-launch: add "Remove items from this creator" button when `!stripe_ready`. \|
805
806	## High friction (developer-default copy and jargon)
807
808	\| ID \| Issue \| Where \| Plan \|
809	\|----\|-------\|-------\|------\|
810	\| UF-H1 \| "Slug" used as a user-facing label across project basics wizard, collections form, tag inputs. \| `wizards/steps/project/basics.html:18,21`, `wizards/wizard_project.html:33`, `partials/tabs/library_collections.html:51-53`, `project_content.html:53` \| Pre-launch: rename to "URL name" everywhere user-facing. Helper copy: "Letters, numbers, hyphens. Used in your URL." \|
811	\| UF-H2 \| Tag input requires dot-notation taxonomy DSL (`audio.genre.ambient`) typed from memory. \| `partials/tabs/project_content.html:53-58` \| Pre-launch: add a `<datalist>` autocompleter from existing tags. Defer the dot-notation power feature behind "Show advanced." \|
812	\| UF-H3 \| "Publish at (UTC)" forces creators to do timezone math. Surfaced a real bug: `parse_schedule_datetime` (`src/helpers.rs:138-152`) falls back to `naive.and_utc()`, so the `<input type="datetime-local">` local-time string was being treated as UTC — silently mis-scheduling publication by the user's TZ offset. \| `partials/tabs/item_details.html:316-318`, `item_settings.html:46-48`, `src/helpers.rs:138` \| CLOSED 2026-05-31. Forms now convert local input to RFC3339 via `htmx:config-request` (`new Date(v).toISOString()`); label reads "Publish at" with hint "Uses your computer's time zone." Display of already-scheduled time still shows UTC raw — defer that cosmetic fix. \|
813	\| UF-H4 \| Generic "Failed" toasts in bulk actions. \| `partials/tabs/project_content.html:286,299,313` \| Pre-launch: replace with actionable copy. \|
814	\| UF-H5 \| "Verify Your Email First" hard-blocks the creator application. Email verification can run in parallel. \| `partials/tabs/user_creator.html:307-318` \| Pre-launch: soften to a banner; allow application submit. \|
815	\| UF-H6 \| First-run dashboard has no orientation; new fan sees a tabbed admin page titled with their username. \| `dashboards/dashboard-user.html` \| Pre-launch: one-line orientation header for first-week users. \|
816	\| UF-H7 \| Subscriptions empty-state says "tier" which is platform jargon for fans. \| `partials/tabs/library_purchases.html:90` \| Pre-launch: "membership" instead of "tier" in fan-facing strings. \|
817	\| UF-H8 \| Footer missing status link. `/health` exists. \| `templates/base.html:33-46` \| Pre-launch: add. \|
818	\| UF-H9 \| Notification preferences collapsed by default behind `<details>` — creators missing emails won't realize the toggle exists. \| `partials/tabs/user_account.html:162` \| Pre-launch: open by default, or split security notifications above the disclosure. \|
819	\| UF-H10 \| Cancel-Fan+ flow opens Stripe portal (two destinations for one task), and "Existing fan subscriptions expire at their billing period end" leaks Stripe-speak. \| `partials/tabs/user_account.html:141-146,243` \| Pre-launch: rewrite the copy to plain English. Defer the dual-destination cleanup. \|
820
821	## Medium friction (defer with rationale)
822
823	- UF-M1: Audio store page has no inline preview (only video is special-cased) — `pages/item.html:70`. Significant template work; defer post-launch.
824	- UF-M2: Collections can be deleted but not edited from the library tab — `partials/tabs/library_collections.html`. Add an edit affordance post-launch.
825	- UF-M3: Owner has no "Edit" link on the public project/collection pages — must navigate to `/dashboard/project`. Defer.
826	- UF-M4: Pause Creator is in Account tab, not Creator tab — `user_account.html:240`. Cross-link or move post-launch.
827	- UF-M5: Custom Domain lives under Profile tab — `user_profile.html:142`. Cross-link from Creator tab post-launch.
828	- UF-M6: License preset rendering ladder duplicated in two templates — `item.html:222-231`, `library_downloads.html:115-124`. Refactor post-launch.
829	- UF-M7: Library has no cross-tab search. Defer.
830	- UF-M8: No keyboard shortcuts beyond ⌘K and `?`. Defer.
831	- UF-M9: No bulk select on subscriptions / invites / promo codes lists. Defer.
832	- UF-M10: No undo on destructive operations. Defer (deletions go through `hx-confirm`).
833	- UF-M11: Item type dropdown not pre-filled from wizard choice — `partials/tabs/item_details.html:39-49`. Defer.
834	- UF-M12: Forgot-password form requires retyping email already entered on `/login`. Defer.
835
836	## Usability wins (preserve)
837
838	- Empty states in `library_collections.html`, `library_feed.html`, `library_purchases.html`, `project_content.html`, `cart.html`, `discover_results.html` explain the next step in plain language.
839	- Wizard project basics doc string maps the DB hierarchy to creator-native metaphors ("A project groups your work — think of it as an album, podcast feed, or product line").
840	- Sandbox banner inside the dashboard explains the ephemerality clearly.
841	- Error page renders only `{{ message }}` plus a contact line — no stack traces leak.
842	- HTMX/JSON content-type dispatch via `helpers.rs:85 is_htmx_request` is consistently applied across CRUD.
843	- Live slug-availability check in the project wizard exists (`api/validate.rs:66`).
844	- The "Connect Stripe (3% processing only)" framing in `project_overview.html:17` is plain English.
845
846	## Pre-launch closure plan
847
848	The 9 BLOCKER items: 5 ship pre-launch (UF-B1, UF-B5, UF-B9) plus doc-only mentions for B3/B6/B8. 4 defer with feature-flag or doc trim (B2, B4, B7).
849
850	The 10 HIGH friction items: all 10 ship pre-launch — they're copy/markup edits.
851
852	The 12 MEDIUM items: defer all to post-launch with this register.
853
854	### Landed 2026-05-31
855
856	- UF-B1 — orphan `library_wishlists.html` and `library_subscriptions.html` deleted.
857	- UF-B9 — Cart group with no Stripe-connected creator now shows "Remove all from {name}" recovery button; `removeCartGroup` JS loops the per-item DELETE.
858	- UF-H1 — "Slug" → "URL name" across `wizards/steps/project/basics.html`, `wizards/wizard_project.html`, `partials/tabs/library_collections.html`. Helper copy rewritten.
859	- UF-H3 — Publish-at form: TZ label fixed, real bug closed via client-side RFC3339 conversion.
860	- UF-H4 — Generic "Failed" toasts in `project_content.html` replaced with actionable copy.
861	- UF-H7 — Subscription empty state now says "memberships" instead of "tier" in fan-facing copy.
862	- UF-H8 — `Status` link added to global footer (`base.html`).
863
864	### Pre-launch items not yet landed (judgment-call or larger scope)
865
866	- UF-H2 — Tag dot-notation autocompleter: needs new datalist source endpoint or client-side cache. ~30 min of work; surfacing for decision.
867	- UF-H5 — Soft-block email verification on creator application: behavior change, needs sign-off.
868	- UF-H6 — Dashboard orientation header for first-week fans: judgment call on copy + audience cohort.
869	- UF-H9 — CLOSED 2026-05-31. `<details>` for Notification Preferences in `user_account.html` now opens by default.
870	- UF-H10 — CLOSED 2026-05-31. Fan+ status copy ("Active until {date}", "Next renewal", "Cancellation scheduled") and Pause-creator description rewritten in plain English; cancel confirm dialog rewritten ("You'll keep access until the end of the month you've paid for").
871
872	Defer the rest to post-launch.
873
874	---
875
876	# Business Sustainability Audit — 2026-05-31
877
878	Run: 2026-05-31. Method: three parallel probes (unit economics, cost blindspots, pricing/revenue/scale). Verifies 0% claims, finds margin-fragile commitments, surfaces existential cost risks.
879
880	## Overall viability grade: B
881
882	The unit economics are actually sound — Hetzner storage + Cloudflare CDN make per-tier margins 80-95% on typical usage, and break-even is ~10 founder creators which is trivially achievable. The fragility is concentrated in a small number of binding promises ("unlimited downloads," "Everything tier always includes future features," "founder rate locked for life," "earn-back credit program") that turn the business into a one-way ratchet toward lower margin. The biggest pre-launch risk is the unmetered egress promise combined with no fair-use language.
883
884	## Critical risks
885
886	\| ID \| Risk \| Evidence \| Pre-launch plan \|
887	\|----\|------\|----------\|-----------------\|
888	\| BF-C1 \| "Unlimited downloads" with no fair-use clause. Direct-from-S3 presigned URLs bypass Cloudflare CDN. A single viral creator's fanbase can outspend their subscription by 100×. \| `guide/tiers.md:24`, `src/architecture.md:42` \| CLOSED 2026-05-31 — added fair-use paragraph to `tiers.md` that keeps the unlimited promise and adds an explicit "if a project drives orders-of-magnitude egress we'll reach out and figure it out" escape hatch. No throttling code; promise integrity preserved. \|
889	\| BF-C2 \| Broadcast handler had a 1/day rate limit but no recipient cap. A creator with 100k followers = 100k emails/day; at Postmark $1.25/k, a hostile or compromised account could spend $4k/mo on email. Auto-announcement scheduler (release + blog post) is worse — no rate limit, no daily cap. \| `src/routes/api/users/broadcast.rs:62-78`, `src/scheduler/announcements.rs` \| PARTIALLY CLOSED 2026-05-31 — added `BROADCAST_MAX_RECIPIENTS = 10_000` constant (`src/constants.rs:154`), check in `broadcast_send` (`src/routes/api/users/broadcast.rs:80-89`), `db::users::clear_broadcast_at` to release the slot on cap-rejection. Doc note in `tiers.md`. Deferred: announcement-scheduler cap — auto-announcements still bypass this. Track post-launch. \|
890	\| BF-C3 \| "Everything tier always includes future features" (`tiers.md:30-32`) + live-streaming on roadmap (`about/roadmap.md` exploration) + "founder rate locked for life" = pre-committing the highest-cost future feature to today's lowest-margin subscribers. \| `guide/tiers.md:30`, `about/roadmap.md` \| Defer (strategic, not pre-launch). Recommendation: soften roadmap copy to flag live-streaming as "if economics work out" rather than "Everything-included." Surface for user decision. \|
891
892	## High risks
893
894	\| ID \| Risk \| Evidence \| Plan \|
895	\|----\|------\|----------\|------\|
896	\| BF-H1 \| Multi-account tier-gaming: `try_increment_storage` gates per-user only; no cross-account dedup against payment method, IP, or email domain. A creator with 10GB of small files could split across two Basic accounts at $16/mo each instead of one Small Files at $24/mo. \| `src/db/creator_tiers.rs:218,568` \| Defer. Founder cohort is hand-picked; at scale add Stripe customer-id cross-check or payment-method fingerprinting. \|
897	\| BF-H2 \| MetaDefender Cloud has no monthly spend cap in code. Currently free-tier (4k req/day) and gated to suspicious files only, so cost = $0 today. If MNW upgrades to a paid key, an uploads-flood from a hostile account would have no spend ceiling. \| `src/scanning/metadefender.rs` \| Defer. Add daily-budget alert + cap before any paid-key upgrade. Note in `tech/content-scanning.md`. \|
898	\| BF-H3 \| Founder rate "locked for life" is a one-way ratchet. Cost-favorable changes apply retroactively; cost-unfavorable changes cannot. \| `site-docs/public/about/guarantees.md`, `site-docs/public/about/pricing.md:14` \| Defer. The legal language is already correct ("locked at the rate when you joined"); business risk is structural and intentional. \|
899	\| BF-H4 \| Earn-back credit program: any creator who pays more than they earn gets credited. Inverts unit economics on small creators — a $5 Basic creator earning $0 gets a year free. Combined with "no ads ever" guarantee + founder rate lock, the long tail of creators is structurally subsidized by the top end. \| `site-docs/public/about/economics.md`, `roadmap.md:54` \| Defer. Strategic decision. Cap the credit to a maximum dollar amount or pair with a minimum-engagement floor before the program goes live (deadline 2027-01-01). \|
900	\| BF-H5 \| Planned: "Content Archive Policy" — content remains hosted free forever after 12 months. Open-ended perpetual storage liability with no offsetting revenue. \| `site-docs/public/about/how-we-work.md:98` (labeled Planned) \| Defer. Recommend bounding the policy ("free hosting for up to 5 years after creator inactivity, then archive offline") before activation. \|
901	\| BF-H6 \| Bus factor = 1 for manual processes: creator approval, DMCA, moderation appeals, support, suspension review, per-file size override requests. None of these scale. \| `src/routes/admin/*.rs` \| Defer. Founder explicitly acknowledges this risk in `support/faq.md:161`. \|
902
903	## Strengths (verified)
904
905	- Unit economics positive at every tier. Even worst-case Small Files at 250GB cap with reasonable egress: ~$3-5/mo cost vs $19.12 net = ~80% gross margin.
906	- Stripe Connect direct charges insulate MNW from refund/chargeback costs. Creator's connected account absorbs Stripe fees, refund processor fees ($0.30), and the $15 chargeback fee. MNW carries none of this on fan sales.
907	- Fan+ is margin-accretive. $7.47/mo net to MNW per Fan+ subscriber. The $5 monthly credit is funded by the connected creator on redemption, not by MNW. (Disclosure gap closed in creator-fuzz round — `guide/fan-plus.md`.)
908	- Break-even at ~10 founder creators. Operating costs are ~$80-150/mo (Hetzner VPS + storage + Postmark + Fastmail + domain amortization). Trivially achievable.
909	- No third-party usage-based service exposure at current scale. All external scanners (ClamAV self-hosted, MalwareBazaar, URLhaus, MetaDefender) are free-tier.
910	- Backups cost $0/mo — off-site sync to astra (owned hardware on Tailscale).
911	- Image processing absent — covers stored as-uploaded, no transcoding pipeline. CPU not a cost driver.
912	- No CDN-bypassing AI APIs, no transcoding, no SMS, no third-party monitoring spend.
913
914	## Pricing observations (not risks)
915
916	- Big→Everything tier value cliff is openly disclosed (`tiers.md:115` "same as Big Files"). Everything is honestly framed as a feature/support tier, not more storage. Not a deceptive design.
917	- Stripe ~$0.62 cost on a $10 Basic subscription = 6.2% real take to Stripe = thin margin compressor on the cheapest tier. Acceptable given Hetzner-low per-tier cost.
918	- No tier above Everything (500GB). A 600GB creator has no purchase path. Recommend a "+1TB at $X/mo" premium storage add-on post-launch — best revenue lever consistent with the brand.
919
920	## Closure plan
921
922	Pre-launch landed:
923	1. BF-C1 — Fair-use paragraph in `guide/tiers.md`. Promise integrity preserved.
924	2. BF-C2 — Broadcast recipient cap (10,000) in code + `db::users::clear_broadcast_at` + doc note. Closes the worst-case Postmark spend bomb.
925
926	Pre-launch surfaced for user decision:
927	3. BF-C3 — Roadmap softening for live streaming. Recommend rewording "Everything tier always includes future features" to make it clearly aspirational for high-cost features.
928
929	Deferred with rationale (post-launch):
930	4. BF-C2-annex — Announcement-scheduler cap (auto-fire on release + blog post). Same shape as the broadcast cap; just a different code path. Add post-launch.
931	5. BF-H1 — Multi-account gaming detection. Founder cohort hand-picked; harmless today.
932	6. BF-H2 — MetaDefender daily budget cap. Currently free-tier; add before any paid upgrade.
933	7. BF-H3, BF-H4, BF-H5 — Earn-back credit cap, locked founder rate, perpetual-archive bound. Strategic; not actionable pre-launch.
934	8. BF-H6 — Bus-factor; documented in faq.md already.
935
936	Revenue gap to explore post-launch: Premium storage add-on above Everything tier. Best lever that respects all guarantees and addresses the actual cost driver (storage + egress on whales).
937
938	---
939
940	# Documentation Fuzz — 2026-05-31
941
942	Run: 2026-05-31. Method: two parallel probes — internal devdocs (`server/docs/`) and private ops docs (`_private/docs/mnw/`). Excluded `audit_review.md` (this file) and `scan-pipeline-audit.md` (historical artifact).
943
944	## High-impact findings landed pre-launch
945
946	### Public docs
947
948	- One-person operation, not "small team." `guide/tiers.md:18` had said "we are a small, profitable team operating without venture capital," contradicting `legal/appeals.md:5`, `about/guarantees.md:97`, and `about/guarantees.md:194` ("one-person operation"). Rewritten to "Makenot.work is a one-person operation today, profitable from day one and operating without venture capital." — CLOSED.
949
950	### Internal devdocs (`server/docs/`)
951
952	- Migration count stale. `schema.md:3` said "57 migrations"; `architecture.md:100` said "50"; reality is 133 and growing. Both replaced with "Numbered migrations in `migrations/`, auto-applied on boot; the directory is the source of truth." — CLOSED.
953	- `schema.md:50` listed `'streaming'` as a valid `creator_tier`. Migration 079 renamed it to `'everything'`. Fixed. — CLOSED.
954	- `schema.md:469-470` documented a `streaming_sessions` table dropped in migration 082. Section removed; the `Content Security` row in the domain map (line 23) also removed. — CLOSED.
955	- `schema.md:133` `web_only` was described as "Prevents download (streaming only)." Actual purpose per migration 041 is "publish without emailing subscribers." Fixed. — CLOSED.
956	- Session cache TTL. `architecture.md:232` said "30-second TTL." Code: `SESSION_TOUCH_CACHE_SECS = 5`. Replaced with the constant name + current value. — CLOSED.
957	- `architecture.md:362` `migrations/` (001-050) — Fixed to "(numbered, applied in order)." — CLOSED.
958	- `frontend.md:111-121` Button Variants table referenced retired bare classes `.primary`, `.secondary`, `.danger`. Replaced with a one-line cross-ref to `design-system.md` and a note that they were retired in favor of `.btn-*`. — CLOSED.
959
960	### Private ops docs (`_private/docs/mnw/`)
961
962	- `server-docs/deploy.md:15` Rust 1.95+ — Reality per `Cargo.toml` is Rust 2024 edition (1.85+). Fixed. — CLOSED.
963	- `server-docs/liability_draft.md:16` "we're a small team" — Fixed to "single-operator platform." — CLOSED.
964	- `server-internal/embeds.md` and `server-internal/tips.md` described shipped features as forward plans. Added a "Status: shipped" header pointing to the public guide and implementation paths. — CLOSED.
965	- `server-docs/doc_coverage_matrix.md:61` Content fingerprinting row — code dropped in migration 082 (`server/src/fingerprint/` no longer exists). Row removed. — CLOSED.
966
967	## Findings logged but not landed (defer with rationale)
968
969	- `docs/cli.md` (617 lines) is ~40% reducible. Multiple ASCII mockups restate the same UI; an 8-phase checklist belongs in `mnw-cli/todo.md`; one section ends with "Wait — that's wrong" then retraction. Real defect, not pre-launch critical. Track post-launch.
970	- Scan-pipeline layer count drift. `architecture.md:201-211` says "6-layer" pipeline. Reality is 9+ layers (`content_type`, `structural`, `archive`, `yara`, `clamav`, `hash_lookup`, `urlhaus`, `metadefender`, `signing_*`). Rewrite needed; not blocking launch.
971	- Rate-limit numbers wrong in multiple docs. `api_reference.md:5`, `architecture.md:90`, `troubleshooting.md:176-178` all cite outdated burst/per-sec numbers. Recommended fix is to drop the absolute numbers and point at `src/constants.rs`. Defer.
972	- `patterns.md:206` UUID claim — "All tables use UUID PKs (except `sync_log` which uses BIGSERIAL)." Several other tables also use BIGSERIAL (scan_jobs, webhook_events, page_views). Defer.
973	- DB submodule and route module counts in `architecture.md:347-348` are off. Recommend dropping the counts; defer.
974	- Test count at `architecture.md:320` ("1,028+ tests (486 unit + 542 integration + ...)") drifts. Drop per the no-status-in-memory rule. Defer.
975	- `docs/oauth_integration.md:84` mentions "MNW maintainers" (plural). Reword to "maintainer." Cosmetic; defer.
976	- `docs/cicd.md:111` references `deploy/promote.sh` that does not exist. Either commit the script or mark "not yet written." Defer.
977	- Repetition between docs (session security in architecture + patterns; HTMX patterns in architecture + frontend + patterns; tier prices in architecture + schema + oauth_integration). Consolidate post-launch.
978	- `_private/docs/mnw/server-docs/liability_draft.md` body duplicates public ToS. Doc says "see public ToS" at line 107 but still restates the same clauses. Recommend trim or archive. Defer.
979	- `_private` arbitration / class-action conflict. `liability_draft.md:66-78` adds binding arbitration + class-action waiver; `legal_review_prep.md:148-151` explicitly says "No arbitration clause. Deliberate." Reconcile against the public `legal/terms-of-service.md`. Defer to legal review.
980
981	---
982
983	# Exorcise — 2026-05-31
984
985	Pass over MNW public-facing markdown. 7 small edits across the 6 files edited earlier this session (fan-plus, tiers, stripe, splits, copyright, security). Em-dashes replaced with periods/colons/parens; "ecosystem" → "platform." Other public docs were checked globally for AI tells (Claude vocab, false contrasts, hedge openers, padding adverbs, decorative unicode) and read clean. No fact issues surfaced.
986
987	---
988
989	# Security Review — pre-launch diff against HEAD (eee96a7) — 2026-05-31
990
991	Verdict: ship. No CRITICAL or HIGH-severity new vulnerabilities. The diff predominantly closes security and correctness gaps; net security posture is improved.
992
993	## Positive observations (gaps closed in this diff)
994
995	- Webhook hot-path `tokio::spawn` migrated to bounded `state.bg.spawn` across ~15 call sites — closes unbounded background fan-out.
996	- `is_full_refund` requires `amount > 0` — closes `pi_unknown` refund-trigger bug.
997	- Cart `toggle_cart` enforces `pf.listed` — closes bundle-only bypass via UUID guessing.
998	- Tip checkout verifies `project.user_id == recipient_id` — closes cross-creator split poisoning.
999	- `compute_splits` proportional scaling — closes >100% pay-out over-credit on misconfig.
1000	- `commit_upload` / `commit_rescan` typestate seal — enforces scan-after-DB-commit ordering across 8 sites including admin paths.
1001	- `pending_uploads::remove_pending_upload(user_id, key)` scoped to `user_id` — closes cross-user pending-uploads collision.
1002	- DUMMY_HASH timing equalizer on malformed login input — closes username-format oracle.
1003	- Stripe webhook returns 503 (not 200) on enqueue failure — closes silent-drop.
1004	- ClamAV `assert_live` boot check + truncated-response → Fail — closes FailOpen false-clean.
1005	- Admin pagination clamped to 1e9 — closes i64 overflow panic.
1006	- Promo code Discount with NULL `discount_type`/`value` hard-fails across all four checkout paths.
1007	- Stripe-readiness check moved BEFORE promo reservation in single + cart paths.
1008	- `pending_subset` pre-check before Stripe session creation + on-collision promo release — closes paid-but-unfulfilled buyer state.
1009	- `expiry_secs` clamp on download presign — closes negative-i32-cast → centuries-long presigned URL.
1010	- `synckit_auth.rs:148` JWT revocation window — closes same-second collision.
1011
1012	## New findings
1013
1014	\| ID \| Sev \| Where \| Issue \| Plan \|
1015	\|----\|-----\|-------\|-------\|------\|
1016	\| SR-M1 \| MED \| `src/routes/pages/public/sitemap.rs:58-89` \| Sitemap query is uncached on cold start and thundering-herd writable. Two `fetch_all` queries scan `users JOIN projects JOIN items` up to 5k/20k rows; on process restart, concurrent crawlers can saturate the DB pool before the first response writes the cache. `robots.txt` does not disallow `/sitemap.xml`. \| Post-launch: single-flight `tokio::sync::Mutex` or pre-warm at boot. Also add `Cache-Control: public, max-age=600`. \|
1017	\| SR-M2 \| MED \| `src/metrics.rs:289-316` \| `idempotency_middleware` negative cache `NEG_CACHE: DashMap<(String, UserId), Instant>` has no max-size bound. GC runs every ~1024 inserts. An authenticated user can spray 1M unique `Idempotency-Key` values before the next GC, blowing up process memory. \| Post-launch: bound by `neg_cache.len() > 100k → GC` or swap for `mini-moka` LRU. Verify request-side cap on idem-key length. \|
1018	\| SR-L1 \| LOW \| `templates/base.html:13-22` vs per-page templates \| `og:title`, `og:url`, `og:image` blocks were added to `base.html` as overridable blocks, but per-page templates still emit literal `<meta property="og:title" ...>` in their own `{% block head %}`. Result: duplicate OG tags. Social scrapers pick the generic default. Not a vulnerability — SEO regression. \| CLOSED 2026-05-31. Per-page-overrideable OG blocks removed from `base.html`; only `og:site_name`, `og:type`, `twitter:card` remain global. Per-page templates that emit their own OG tags (9 templates) now stand alone; pages without overrides get a minimal but valid card. Build verified clean. \|
1019	\| SR-L2 \| LOW \| `templates/pages/error.html:11-12` \| "Go Back" link removed; `history.back()` was the only way back from an error page. UX, not security. \| Defer or restore the link. \|
1020	\| SR-L3 \| LOW \| `src/pricing.rs:21-35` \| `parse_dollars_to_cents` strips `$`, `,`, whitespace before parsing. European decimal `"1,5"` silently parses as `15` (1500¢). Not exploitable (creator's own money); UX foot-gun. \| Defer; consider rejecting comma-as-decimal-separator inputs. \|
1021	\| SR-L4 \| LOW \| `src/routes/stripe/webhook/subscriptions.rs:14-31` \| Unknown Stripe statuses log `warn!` and the dedup row is marked processed. A future Stripe state (e.g., `paused`) would be silently swallowed. \| Defer; add an ops alert on the `"unknown stripe status"` log line. \|
1022	\| SR-L5 \| LOW \| `templates/pages/cart.html:209-223` \| `removeCartGroup` fires N parallel DELETEs with `csrfHeaders()`. Assumes CSRF is wired correctly via the meta tag and that `/api/cart/:id DELETE` enforces CSRF at the route layer. Verified almost-certainly OK; one grep would confirm. \| Verify pre-launch; no fix expected. \|
1023	\| SR-L6 \| LOW \| `src/scheduler/cleanup.rs:36-62` \| `JoinSet` swallows panic per task; a panicking S3-cleanup task would leave the user row in expired state. Pre-existing semantics; not a regression. \| Monitor only. \|
1024	\| SR-L7 \| LOW \| `src/routes/pages/public/content/mod.rs:32-37` \| `track_view` page-view batcher silently drops on full channel. Correct under burst (view-counts under-count rather than block). Confirm `warn` log on drop so a stuck flusher is visible. \| Verify logging only. \|
1025	\| SR-L8 \| LOW \| `src/routes/oauth.rs:209-220` \| `state` capped at 1024 bytes, `code_challenge` at 44 (S256-only). RFC 7636 allows up to 128; current cap is consistent because S256 is hard-coded. \| No fix needed. \|
1026
1027	## Pre-launch closure for security review
1028
1029	- SR-L1 (duplicate og: tags) is the one launch-day-relevant item. Surfaced for decision: either remove the new `{% block og_* %}` from `base.html`, or migrate per-page templates. The current state is benign-but-suboptimal for social-share previews.
1030	- All MED items deferred to first post-launch week with watchlist.
1031
1032	---
1033
1034	# Ultra Fuzz — Run #9 — 2026-05-31
1035
1036	Run date: 2026-05-31 (pre-launch). Five parallel adversarial axes on `MNW/server` HEAD + uncommitted session changes.
1037
1038	## Headline
1039
1040	\| Axis \| Run #8 \| Run #9 \| Direction \|
1041	\|------\|--------\|--------\|-----------\|
1042	\| Payments \| A- \| A- \| flat — 0 CRITICAL/SERIOUS, 2 new MEDs (delayed-session race signal, "unknown" PI placeholder) \|
1043	\| Storage \| A- \| A- \| flat — 1 new SERIOUS: rollback over-correction in `project_image_confirm`; sibling MEDs around CDN-URL parsing, enqueue-outside-tx \|
1044	\| UX Wiring \| A- \| A- \| flat — 1 false-positive CRITICAL (filename XSS — filenames are pre-sanitized at `media.rs:236`); 2 real SERIOUS landed/closed this run; 1 deferred (client-side TZ JS dependency) \|
1045	\| Security \| A- \| B+ → A- \| held at A- after verification: 3 SERIOUS findings are defense-in-depth recommendations, not active exploits at private-alpha scale \|
1046	\| Performance \| A- \| B+ \| ↓ regression: 3 SERIOUS — buyer-departure fan-out unbounded (same disease class as broadcast cap), in-scheduler S3 sweeps under advisory lock, build hook fire-and-forget curl \|
1047
1048	Net Run #9 (pre-fix): 0 CRITICAL real (1 false positive), 8 SERIOUS open, 18+ MED.
1049
1050	Pre-launch landed this run:
1051	- UX SERIOUS — orphan `item_settings.html` Publishing block deleted (template file + route + handler + struct + re-exports). Removes the duplicate `id="schedule-form"` / `id="publish-at"` collision potential. Build verified clean.
1052	- UX SERIOUS — `removeCartGroup` partial-failure handling fixed: now tracks failure flag, reloads on any failure to reconcile DOM with server state. Build verified clean.
1053
1054	Pre-launch verified as false positives or design intent (no action):
1055	- UX CRITICAL (filename XSS in `user_media.html`) — filenames are sanitized at `src/routes/storage/media.rs:236-239` to `[A-Za-z0-9._-]` only. No quote/backslash/newline can land in the template. Pattern is fragile but data-shape closed. Logged as a defense-in-depth nitpick for post-launch.
1056	- Performance N-3 (broadcast `tokio::time::sleep` outside parallelism gate) — `constants::BROADCAST_CHUNK_DELAY_MS = 100ms` is documented and intentional steady-state throttling at ~10 sends/sec to be polite to Postmark. Not a bug.
1057
1058	## Critical findings — fix before launch
1059
1060	None real. C1 filename-XSS finding was a false positive (verified via upstream sanitization).
1061
1062	## Bug reports by axis
1063
1064	### Payments (A-, no change)
1065	- MED-1 Stale pending-tx cleanup deletes by `status='pending' AND created_at < cutoff` — if Stripe delivers a delayed `checkout.session.completed` past the cutoff (rare; happens during Stripe incidents), `complete_transaction` returns `None` and the buyer is charged with no library entry. Log signal is identical to true-duplicate. Recommend distinct log message + 25h cutoff (`src/db/transactions.rs:1033`). Defer.
1066	- MED-2 `complete_transaction` writes literal `"unknown"` when `session.payment_intent` is missing. A future `charge.refunded` against a real PI can't match the row; theoretical fan-out risk if two such rows exist (`src/routes/stripe/webhook/checkout.rs:38,127,504,555`). Recommend nullable column or fail-and-retry. Defer.
1067	- 3 MINOR (i32 cents in cart, no PWYW ceiling, race-warn log granularity). Defer.
1068	- Mandatory surprise (positive): `compute_splits` test suite pins the previous-incarnation `60+60% paid $12 on $10` bug with a named regression test that explains itself. Unusually disciplined.
1069
1070	### Storage (A-, no change)
1071	- SERIOUS-1 `project_image_confirm` rollback over-corrects storage counter when the prior S3 object was zero-byte or transiently `None` on first probe but resolves to a real size on the rollback re-probe. `storage_used` ends up at `original + old_size` instead of `original`. Real but rare; race window depends on S3 eventual consistency for the same key (`src/routes/storage/images.rs:208-272`). Defer post-launch; track. Structurally the duplicated rollback logic across 7 confirm handlers is the underlying issue — extend `commit_upload` typestate to rollback.
1072	- MED-2 `extract_s3_key_from_url` returns `None` for CDN URLs after CDN config is unset → silent skip of old-key cleanup (`src/routes/storage/images.rs:160-198`). Defer.
1073	- MED-3 `media_delete` enqueues `pending_s3_deletions` outside the transaction. Process crash between tx-commit and enqueue → permanent S3 orphan. Move enqueue into the tx (`src/routes/storage/media.rs:401-415`). Defer.
1074	- MED-4 `is_s3_key_live` cross-table OR-EXISTS with LIKE-on-URL predicates can't use a btree at scale. Defer.
1075	- MED-5 `record_pending_upload` ON CONFLICT silently no-ops on cross-user collision — unreachable by route-prefix validation today, but the DB primitive shouldn't bank on that. Defer.
1076	- 4 MINOR. Defer.
1077	- Mandatory surprise: `downloads.rs:124-130` audio-stream presigned URL TTL scales with `duration_seconds`, capping at 24h — for a long audiobook, the URL is effectively a permanent download credential for that window. Policy call, not a bug.
1078
1079	### UX Wiring (A-, with 2 fixes landed)
1080	- CRITICAL (false positive) filename XSS in `user_media.html:66` — filenames are pre-sanitized at `media.rs:236-239`. No exploit; defense-in-depth nitpick deferred.
1081	- SERIOUS-1 Orphan Publishing block in `item_settings.html` with duplicate IDs. CLOSED 2026-05-31 — orphan template + route + handler + struct removed.
1082	- SERIOUS-2 `removeCartGroup` swallowed partial failures, leaving DOM inconsistent with server state. CLOSED 2026-05-31 — now sets failure flag, reloads on any failure.
1083	- SERIOUS-3 Client-side TZ math via `htmx:config-request` (this session's `new Date(v).toISOString()` conversion) depends on JS. The `datetime-local` input itself depends on JS-capable browsers; defensible. Defer the server-side-conversion proposal post-launch.
1084	- MEDs: promo code / license key interpolated into inline `onclick=` (M1 — data-shape closed today like the filename case, fragile pattern), inline rename swallows server validation errors (M2), pwyw client min not enforced on blur (M3), wizard slug "locked" hint context note (M4), license-key double-restore timeout race (M5). Defer all.
1085	- 6 MINOR. Defer.
1086	- Mandatory surprise: the duplicate Publishing block was load-bearing — `item_details.html:273` literally says "merged from Settings" but the merge target kept the orphan. Closed this run.
1087
1088	### Security (B+/A-, no real exploits)
1089	- SER-1 Cloudflare IP header is the sole trust anchor for rate limiting & abuse caps. If Hetzner-origin firewall drifts off the Cloudflare allowlist, attacker can spoof `CF-Connecting-IP` and bypass per-IP locks. Defense-in-depth: cross-check `CF-Connecting-IP` against TCP remote addr's membership in the Cloudflare allowlist (`src/helpers.rs:40-64`, `src/rate_limit.rs:17-32`). Pre-existing posture appropriate for private alpha; add for public-traffic phase. Defer.
1090	- SER-2 Broadcast slot-clear-on-reject permits a creator to probe their own follower count past/under the 10k cap by polling. Low-impact disclosure (self-leak). Defer.
1091	- SER-3 TOTP replay check is not atomic — concurrent submissions of the same valid code can both pass before either UPDATE lands. Real but bounded (same user replays their own code) (`src/routes/pages/public/two_factor.rs:188-191`). Fix to single conditional UPDATE. Defer.
1092	- MEDs: `removeCartGroup` swallow check already closed above; `delete_all_sessions_for_user` non-tx ordering (MED-4); `is_localhost_redirect` accepts arbitrary paths/queries (MED-5); backup-code Argon2 loop CPU-burn (MED-6); `create_report` accepts arbitrary `target_id` (MED-7); `final_status` doesn't warn on `Skip` from typo'd layer name (MED-8). All defer.
1093	- Mandatory surprise: `DUMMY_HASH` `LazyLock` cold-start pays a synchronous ~600ms Argon2 hash on the very first login post-deploy. A `spawn_blocking` warmup at server start would eliminate the first-request stall (`src/auth.rs:30-32`). Defer.
1094
1095	### Performance (B+, regression from A-)
1096	- S-1 `get_all_buyers_for_seller` is fully unbounded (`src/db/transactions.rs:781`) and the `pause/delete creator` notification path loops through every buyer serially via `tokio::spawn` (`src/routes/api/users/profile.rs:204`). A creator with many sales triggers an unbounded `Vec` allocation + serial Postmark burst with no rate limit. Same disease class as the BROADCAST_MAX_RECIPIENTS cap landed this session, missed in this path. Pre-launch: low risk because account deletion is rare; defer with watchlist (apply the same cap+streaming pattern post-launch).
1097	- S-2 `cleanup_user_s3_and_delete` runs S3 deletes per user / per project / per SyncKit app blob + ota prefix sequentially inside the scheduler's `pg_try_advisory_lock` (`src/scheduler/cleanup.rs:100-123`, `src/scheduler/mod.rs:99-279`). A tick with 5 terminated creators × 20 projects each will exceed `TICK_DURATION_ALERT_SECS=50s`. Wrap in `state.bg.spawn` or move to the scan worker pool pattern. Defer.
1098	- S-3 Build runner post-receive hook is fire-and-forget `curl & >/dev/null 2>&1` (`src/build_runner.rs:16-44`). No retry, no log, no failure surface. Defer.
1099	- MEDs: sitemap herd (M-1 — known from security-review, deferred), NEG_CACHE GC on hot path (M-2 — known, deferred), serial `delete_prefix` not batched (M-3), scheduler skips on acquire-failure with no backoff (M-4), health monitor probes too aggressive (M-5), buffered Vec for buyers (M-6 dup of S-1). Defer all.
1100	- Mandatory surprise: `check_sandbox_cap` (`src/db/mod.rs:83-128`) holds `pg_try_advisory_lock` across a `COUNT(*)` on `users JOIN user_sessions WHERE us.ip_address = $1`. The lock-key partition is per-IP so it can't cross-deadlock, but a single hot IP (campus / café NAT) burns one full pool slot for the COUNT duration. The fix for a prior cross-conn-unlock bug introduced a per-IP slow-query amplifier. Verify `user_sessions(ip_address)` is indexed (likely it is — but verify pre-launch). Defer.
1101
1102	## Confidence assessment
1103
1104	\| Axis \| Confidence \| Note \|
1105	\|------\|-----------\|------\|
1106	\| Payments \| HIGH \| Run #5-#9 hardening verified holding; no new attack vectors landed \|
1107	\| Storage \| HIGH \| One real edge-case in image-replace rollback; otherwise sealed \|
1108	\| UX Wiring \| HIGH \| Two real SERIOUS closed this run; rest are JS-disabled and data-shape defense-in-depth \|
1109	\| Security \| MED-HIGH \| Posture appropriate for private alpha; CF-IP-only trust + TOTP TOCTOU should land for public-traffic phase \|
1110	\| Performance \| MED \| B+ grade reflects real serial-fanout / in-lock-S3 patterns that haven't bitten yet but will under heavier load \|
1111
1112	## Launchplan §1.5 bar evaluation
1113
1114	Bar: A- across all axes.
1115
1116	- Payments: A- ✓
1117	- Storage: A- ✓
1118	- UX Wiring: A- ✓ (after closing 2 SERIOUS this run)
1119	- Security: A- ✓ (held; SERIOUS items are defense-in-depth for public-traffic phase)
1120	- Performance: B+ ✗ — first below-bar axis since the regime started.
1121
1122	Per the launchplan rule ("anything graded below A- on Payments / Storage / UX / Security / Performance must be either fixed or explicitly deferred with a written reason in `docs/audit_review.md`"): Performance B+ is deferred with the per-finding rationale above. The three SERIOUS items (S-1 buyer fan-out cap, S-2 in-scheduler S3, S-3 build hook curl) are all pre-existing patterns, none currently exercised at launch-day scale, all logged with concrete fix proposals for the first post-launch sprint.
1123
1124	## Cross-cutting concerns
1125
1126	1. Unbounded fan-out is a chronic pattern. Run #8 fixed webhook hot-path `tokio::spawn` via `state.bg`. Run #9 finds the buyer-departure notification path with the same disease (S-1), plus closes broadcast cap (this session, BF-C2). The chronic fix shape: any path that emails N recipients should go through a bounded `state.bg.spawn` + recipient cap + retryable job row. Constructive impossibility candidate for a future structural fix: a `BroadcastBudget` extractor that any per-recipient-email handler must consume; the extractor's constructor enforces the cap and queues a job row. Migration: list `tokio::spawn` sites that send N emails; convert to the extractor.
1127
1128	2. Inline `onclick=` with template-interpolated strings is a chronic XSS shape. Multiple sites today (cart removeCartGroup before this session, user_media.html, promo_codes_list.html, library_purchases.html). Each is data-shape-safe because of upstream sanitization or system-generated alphanumeric values, but the pattern compounds risk. Structural fix: a CONTRIBUTING.md rule + lint that prohibits Askama interpolation inside `onclick=` / `on=` attributes, with `data-` + delegated listeners as the only sanctioned pattern. The pattern landed clean in `removeCartGroup` is the model.
1129
1130	3. Rollback logic duplicated across 7 confirm handlers continues to spawn the same class of bug (Storage SERIOUS-1 this run; prior runs had similar). Extend the `commit_upload` typestate seal to cover the failure path with a `ConfirmGuard`-style RAII that auto-reverts storage credit on drop unless `.commit()` was called.
1131
1132	## Pre-launch closure plan
1133
1134	Landed this run:
1135	- UX SERIOUS-1 (orphan Publishing block in item_settings.html) — deleted template + route + handler + struct.
1136	- UX SERIOUS-2 (removeCartGroup partial-failure DOM inconsistency) — failure-flag + reload on any failure.
1137
1138	Deferred with written rationale (above):
1139	- All 7 remaining SERIOUS items across Storage, Security, Performance.
1140	- All 18+ MED items.
1141	- Both chronic patterns (unbounded fan-out, inline-onclick interpolation) — structural fixes proposed for post-launch.
1142
1143	Performance B+ is the only below-bar axis and is documented for first post-launch sprint with three concrete fix items.
1144
1145	### Performance SERIOUS items — landed 2026-05-31 (post-Run #9)
1146
1147	After Run #9 surfaced three SERIOUS items dropping Performance to B+, all three were closed in the same session. Net post-fix grade: Performance A-, bringing the launchplan §1.5 bar to A- across all 5 axes.
1148
1149	#### S-1 CLOSED — Buyer-departure fan-out bounded
1150
1151	- `src/db/transactions.rs::get_all_buyers_for_seller` now takes a `limit: i64` parameter; SQL adds `LIMIT $2`.
1152	- `src/constants.rs::BUYER_DEPARTURE_MAX_NOTIFICATIONS = 50_000` — generous cap that bounds memory + outbound email volume.
1153	- New helper `src/email::send_creator_departure_notifications` collapses the duplicated fan-out logic from both call sites (`routes/api/users/profile.rs:197` and `routes/pages/email_actions/account.rs:170`). Uses the same `JoinSet` + `BROADCAST_PARALLELISM` + `BROADCAST_CHUNK_DELAY_MS` cadence shape as `routes/api/users/broadcast.rs`, so Postmark backpressure profile is identical and one constant change retunes both.
1154	- If the cap is hit, a `tracing::warn!` flags the user_id, count, and cap for manual follow-up; otherwise an info-level "sending creator departure notifications" with buyer_count.
1155	- Build clean.
1156
1157	#### S-2 CLOSED — Account-cleanup S3 sweeps moved off scheduler advisory lock
1158
1159	- `src/scheduler/cleanup.rs::delete_expired_terminated_accounts` and `delete_expired_content_removal_accounts` refactored to share a `spawn_expired_account_cleanups` helper that `tokio::spawn`s per-user `cleanup_user_s3_and_delete` calls instead of awaiting them serially.
1160	- Each step in `cleanup_user_s3_and_delete` is idempotent: `delete_prefix` on missing prefix is a no-op, CASCADE `delete_user` on a non-existent row affects zero rows. Worst-case race (a second tick fires before all spawned cleanups finish) yields at most one harmless duplicate sweep against an in-flight target.
1161	- `scheduler_jobs` row now records the scheduled count, not deleted count, with a comment explaining the semantic (deletes finish out of band; per-user success/failure is logged inside `cleanup_user_s3_and_delete`).
1162	- Net effect: scheduler advisory lock no longer extends across S3 multi-page `delete_prefix` calls. Tick duration is decoupled from per-user content volume.
1163	- Build clean.
1164
1165	#### S-3 CLOSED — Build-runner post-receive hook now logs failures
1166
1167	- `src/build_runner.rs::POST_RECEIVE_HOOK_TEMPLATE` rewritten to:
1168	- Extract `REPO_PATH`, `LOG`, `OWNER`, `REPO_NAME` once at the top of the hook (was duplicated per branch).
1169	- Wrap each curl in a backgrounded subshell with `exec >>"$LOG" 2>&1` so stdout + stderr append to `hooks/post-receive.log`.
1170	- Prefix each invocation with `[<RFC3339 UTC>] tag-push\|branch-push $OWNER/$REPO_NAME ...`.
1171	- On non-zero curl exit, write a `FAILED builds/trigger\|issues/process-push exit=$?` line so a missed build is diagnosable from the repo.
1172	- Backgrounded execution preserved — git push still returns immediately.
1173	- Log grows unbounded; comment notes that host logrotate is the truncation mechanism. Acceptable for the current scale.
1174	- Build clean.
1175
1176	### Updated launchplan §1.5 bar
1177
1178	\| Axis \| Run #8 \| Run #9 (pre-fix) \| Run #9 (post-fix) \|
1179	\|------\|--------\|------------------\|-------------------\|
1180	\| Payments \| A- \| A- \| A- \|
1181	\| Storage \| A- \| A- \| A- \|
1182	\| UX Wiring \| A- \| A- \| A- \|
1183	\| Security \| A- \| A- \| A- \|
1184	\| Performance \| A- \| B+ \| A- \|
1185
1186	Launchplan §1.5 bar met: A- across all 5 axes.
1187
1188
1189
1190
1191
1192
1193