Skip to main content

max / makenotwork

Stop synckit-client leaking a second TLS stack into consumers The reqwest dependency omitted `default-features = false`, and reqwest 0.13 changed `default-tls` from native-tls to rustls. Cargo unions features across the graph, so this pulled rustls, aws-lc-rs and its cmake build into every consumer even though audiofiles and goingson each correctly disable defaults in their own manifests. native-tls remained the active backend, so the second stack was compiled and never used. Re-add charset, http2 and system-proxy explicitly. They are reqwest defaults that consumers were receiving only through this dependency, so disabling defaults without them would have silently dropped HTTP/2 and system proxy support. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Author: Max Johnson <me@maxj.phd> · 2026-07-21 17:44 UTC
Commit: c836558294424db6d2daf44889e503192ad4f038
Parent: d7a50c5
1 file changed, +1 insertion, -1 deletion
@@ -31,7 +31,7 @@ zeroize = "1"
31 31 sha2 = "0.10"
32 32
33 33 # HTTP
34 - reqwest = { version = "0.13", features = ["json", "native-tls", "stream", "form"] }
34 + reqwest = { version = "0.13", default-features = false, features = ["json", "native-tls", "stream", "form", "charset", "http2", "system-proxy"] }
35 35 bytes = "1"
36 36 tokio = { version = "1", features = ["rt-multi-thread", "macros", "time", "fs", "io-util"] }
37 37 tokio-stream = "0.1"