Skip to main content

max / makenotwork

Fix the clippy and test failures the newly configured gates found None of these were regressions; they were caught the first time the gates that cover them actually ran on the Sando host (rebuild 27). clippy, five errors in makenotwork. Three redundant references in format! arguments, in bulk item copy and the two API-key masking sites; two assert! equality comparisons in tier_prices that should be assert_eq!, which also gives a useful message on failure instead of just "assertion failed". The two test failures were the same bug twice, and it belongs to c8ff4d2b ("Spell the product name Makenotwork everywhere it is displayed"). That commit renamed the displayed string and missed two assertions that were still matching the old one: - admin::health_gates_full_dashboard_to_admins asserted the anonymous status page contains "MakeNotWork". The page correctly renders "Makenotwork". The brand doc lists "MakeNotWork" as a spelling never to use, so the test was asserting the forbidden form. - exports::content_export_zips_files_and_uploads_to_s3 asserted the export README manifest starts "Makenot.work Content Export"; it is "Makenotwork Content Export" (src/routes/api/exports/content.rs:416). Fixed the assertions rather than the code: in both cases the code was right and only the expectation was stale. Two forbidden spellings survive on purpose. tests/workflows/sso.rs's module comment is prose about the delegated-login button, and src/auth.rs:887 sends "MakeNotWork-Security-Check" as an outbound User-Agent, which is an identifier a remote service may match on rather than displayed copy. Neither is UI. Green under the gate's own invocations: cargo clippy --all-targets --features fast-tests -D warnings, cargo fmt --check, and the full suite (1912 unit, 1215 integration, 0 failed).
Co-Authored-By
Claude Opus 5 (1M context) <noreply@anthropic.com>
Author: Max Johnson <me@maxj.phd> · 2026-08-03 17:23 UTC
Signed with PGP, not checked
Commit: 5586c50f8ce1732816ef56bba2f5ae4e08f86cfe
Parent: 1dd6a1a
7 files changed, +11 insertions, -11 deletions
@@ -10473,10 +10473,6 @@
10473 10473 name = "painhours"
10474 10474 version = "0.1.0"
10475 10475
10476 - [[patch.unused]]
10477 - name = "supernote-push"
10478 - version = "0.1.0"
10479 -
10480 10476 [[patch.unused]]
10481 10477 name = "synckit-client"
10482 10478 version = "0.6.0"
@@ -10484,3 +10480,7 @@
10484 10480 [[patch.unused]]
10485 10481 name = "synckit-config"
10486 10482 version = "0.1.2"
10483 +
10484 + [[patch.unused]]
10485 + name = "supernote-push"
10486 + version = "0.1.0"
@@ -334,8 +334,8 @@
334 334 );
335 335 // ISO 8601 date format: YYYY-MM-DD.
336 336 assert_eq!(r.last_updated_iso.len(), 10);
337 - assert!(r.last_updated_iso.chars().nth(4) == Some('-'));
338 - assert!(r.last_updated_iso.chars().nth(7) == Some('-'));
337 + assert_eq!(r.last_updated_iso.chars().nth(4), Some('-'));
338 + assert_eq!(r.last_updated_iso.chars().nth(7), Some('-'));
339 339 }
340 340
341 341 #[test]
@@ -71,7 +71,7 @@
71 71 "health must stay publicly reachable"
72 72 );
73 73 assert!(
74 - anon.text.contains("MakeNotWork"),
74 + anon.text.contains("Makenotwork"),
75 75 "anon gets the minimal status page"
76 76 );
77 77 assert!(
@@ -421,7 +421,7 @@
421 421 zip.len()
422 422 );
423 423 assert!(
424 - contains_bytes(&zip, b"Makenot.work Content Export"),
424 + contains_bytes(&zip, b"Makenotwork Content Export"),
425 425 "zip must include the README manifest"
426 426 );
427 427 assert!(
@@ -223,7 +223,7 @@
223 223 .bind(user_id)
224 224 .fetch_one(&mut *tx)
225 225 .await?;
226 - let copy_title = format!("Copy of {}", &source.title);
226 + let copy_title = format!("Copy of {}", source.title);
227 227 let copy_title: String = copy_title.chars().take(200).collect();
228 228 let base_slug = crate::helpers::slugify(&copy_title).to_string();
229 229
@@ -726,7 +726,7 @@
726 726 for app in &db_apps {
727 727 let (device_count, log_entry_count) = stats_map.get(&app.id).copied().unwrap_or((0, 0));
728 728
729 - let api_key_masked = format!("{}...", &app.api_key_prefix);
729 + let api_key_masked = format!("{}...", app.api_key_prefix);
730 730 let keys_secret_masked = app.keys_secret_prefix.as_ref().map(|p| format!("{p}..."));
731 731
732 732 let billing = billing_map.get(&app.id).map(|b| {
@@ -117,7 +117,7 @@
117 117 for app in db_apps {
118 118 let (device_count, log_entry_count) = stats_map.get(&app.id).copied().unwrap_or((0, 0));
119 119
120 - let api_key_masked = format!("{}...", &app.api_key_prefix);
120 + let api_key_masked = format!("{}...", app.api_key_prefix);
121 121 let keys_secret_masked = app.keys_secret_prefix.as_ref().map(|p| format!("{p}..."));
122 122
123 123 // Resolve linked project name/slug