Skip to main content

max / goingson

Offer Keep 10 backups, the retention value a fresh install starts on backup_scheduler.rs seeds max_backups_to_keep at 10, which neither retention list carried, so a fresh install had no option matching its own setting. b72c6d8 stopped that from silently rewriting the value; this gives it a labelled option instead of the bare generated one.
Author: Max Johnson <me@maxj.phd> · 2026-07-26 20:58 UTC
Signed with PGP, not checked
Commit: 5bb11dd0a7426f9a75a710b3d701385769c3036a
Parent: b72c6d8
2 files changed, +7 insertions, -0 deletions
@@ -241,6 +241,9 @@
241 241 { value: 1, label: 'Keep 1 backup (Recommended)' },
242 242 { value: 3, label: 'Keep 3 backups' },
243 243 { value: 7, label: 'Keep 7 backups' },
244 + // 10 is what backup_scheduler.rs seeds a fresh install with, so the
245 + // list has to carry it or that default has no option to select.
246 + { value: 10, label: 'Keep 10 backups' },
244 247 { value: 14, label: 'Keep 14 backups' },
245 248 { value: 0, label: 'Keep all backups' },
246 249 ];
@@ -221,6 +221,10 @@
221 221 { value: 1, label: 'Keep 1 backup (Recommended)' },
222 222 { value: 3, label: 'Keep 3 backups' },
223 223 { value: 7, label: 'Keep 7 backups' },
224 + // 10 is what backup_scheduler.rs seeds a fresh install with, so
225 + // the list has to carry it or that default has no option to
226 + // select. Duplicated in export.js's backup settings modal.
227 + { value: 10, label: 'Keep 10 backups' },
224 228 { value: 14, label: 'Keep 14 backups' },
225 229 { value: 0, label: 'Keep all backups' },
226 230 ];