Skip to main content

max / goingson

Sync contact test fixtures with NewContact/UpdateContact field split NewContact gained is_implicit; UpdateContact lost it (immutable after creation). Tests had drifted — add the field to create cases and remove it from update cases. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Author: Max J. <87768334+MaxJMath@users.noreply.github.com> · 2026-05-14 19:26 UTC
Commit: 54bc9f97ad95efc8736b77205c1841ee29f425f8
Parent: f869177
2 files changed, +2 insertions, -3 deletions
M crates/db-sqlite/tests/contact_repo_tests.rs +2 -2
@@ -51,6 +51,7 @@ async fn create_contact_with_optional_fields() {
51 51 tags: vec!["work".to_string(), "engineering".to_string()],
52 52 birthday: Some(chrono::NaiveDate::from_ymd_opt(1990, 6, 15).unwrap()),
53 53 timezone: Some("America/New_York".to_string()),
54 + is_implicit: false,
54 55 };
55 56
56 57 let created = repo.create(user_id, new).await.unwrap();
@@ -82,6 +83,7 @@ async fn list_all_contacts() {
82 83 tags: vec![],
83 84 birthday: None,
84 85 timezone: None,
86 + is_implicit: false,
85 87 };
86 88 repo.create(user_id, new).await.unwrap();
87 89 }
@@ -122,7 +124,6 @@ async fn update_contact() {
122 124 tags: vec!["friend".to_string()],
123 125 birthday: None,
124 126 timezone: None,
125 - is_implicit: false,
126 127 };
127 128
128 129 let updated = repo.update(created.id, user_id, update).await.unwrap().unwrap();
@@ -147,7 +148,6 @@ async fn update_nonexistent_returns_none() {
147 148 tags: vec![],
148 149 birthday: None,
149 150 timezone: None,
150 - is_implicit: false,
151 151 };
152 152
153 153 let result = repo.update(ContactId::new(), user_id, update).await.unwrap();
M src-tauri/src/commands/tests/contact_tests.rs -1
@@ -121,7 +121,6 @@ async fn update_contact() {
121 121 tags: vec!["updated".to_string()],
122 122 birthday: None,
123 123 timezone: None,
124 - is_implicit: false,
125 124 };
126 125
127 126 let updated = state