Skip to main content

max / audiofiles

Adopt lint block, pin stable toolchain, cargo fmt, fix clippy Wire the shared clippy::pedantic block across all members, pin channel=stable, normalize with cargo fmt, and reach green under -D warnings: write! over format!-push (no unwrap, per deny(unwrap_used)), clone_from, let-else, #[must_use], concrete Default types, borrow/by-value where appropriate, saturating_sub for a guarded time subtraction. Scoped #[allow]s (with reasons) for test float compares, closure-signature-bound params, and the worker_runtime step-fn contract. clippy.toml spawn seal and deny(unwrap_used) attributes untouched.
Co-Authored-By
Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Author: Max Johnson <me@maxj.phd> · 2026-07-24 15:43 UTC
Signed with PGP, not checked
Commit: 4de4d6133deb94ce97d2ae869542db22f9b90a3c
Parent: 587ca59
154 files changed, +1805 insertions, -1620 deletions
M Cargo.toml +32
@@ -58,3 +58,35 @@
58 58 midir = "0.11"
59 59 tagtree = { path = "../../MNW/shared/tagtree" }
60 60 makeover = "2.0.0"
61 +
62 + [workspace.lints.rust]
63 + unused = "warn"
64 + unreachable_pub = "warn"
65 +
66 + [workspace.lints.clippy]
67 + pedantic = { level = "warn", priority = -1 }
68 + # Allow-list tuned from a measured breakdown across server/multithreaded/pter
69 + # (2026-07-22). These are the high-churn / low-signal pedantic lints; everything
70 + # else in `pedantic` stays a warning. Keep this block identical across repos.
71 + module_name_repetitions = "allow"
72 + # Doc lints. No docs-completeness push is underway.
73 + missing_errors_doc = "allow"
74 + missing_panics_doc = "allow"
75 + doc_markdown = "allow"
76 + # Numeric casts. Endemic and mostly intentional in size and byte math.
77 + cast_possible_truncation = "allow"
78 + cast_sign_loss = "allow"
79 + cast_precision_loss = "allow"
80 + cast_possible_wrap = "allow"
81 + cast_lossless = "allow"
82 + # Subjective structure and style nags. High churn, low signal.
83 + must_use_candidate = "allow"
84 + too_many_lines = "allow"
85 + struct_excessive_bools = "allow"
86 + similar_names = "allow"
87 + items_after_statements = "allow"
88 + single_match_else = "allow"
89 + # Frequent false-positives in TUI and router-heavy code.
90 + match_same_arms = "allow"
91 + unnecessary_wraps = "allow"
92 + type_complexity = "allow"
@@ -28,7 +28,7 @@
28 28 rfd = { workspace = true }
29 29 toml = { workspace = true }
30 30 # Pinned to the v1 store bundle explicitly: Apple Keychain, Windows credential
31 - # manager, and Secret Service on Linux. Do not enable `linux-keyutils-keyring-store` —
31 + # manager, and Secret Service on Linux. Do not enable `linux-keyutils-keyring-store`,
32 32 # that backing store is in-memory and drops every entry on reboot, which silently
33 33 # destroyed stored secrets before keyring 4 moved the default to Secret Service.
34 34 keyring = { version = "4", default-features = false, features = ["v1"] }
@@ -39,3 +39,6 @@
39 39 [target.'cfg(target_os = "linux")'.dependencies]
40 40 eframe = { version = "0.35", default-features = false, features = ["default_fonts", "glow", "x11", "wayland"] }
41 41 gtk = "0.18"
42 +
43 + [lints]
44 + workspace = true
@@ -12,3 +12,6 @@
12 12 serde = { workspace = true }
13 13 serde_json = { workspace = true }
14 14 rayon = { workspace = true }
15 +
16 + [lints]
17 + workspace = true
@@ -43,3 +43,6 @@
43 43 [target.'cfg(target_os = "windows")'.dependencies]
44 44 windows = { version = "0.62", features = ["Win32_Foundation", "Win32_System_Com", "Win32_System_Com_StructuredStorage", "Win32_System_Ole", "Win32_System_Memory", "Win32_System_SystemServices", "Win32_Graphics_Gdi", "Win32_Storage_FileSystem"] }
45 45 windows-core = "0.62"
46 +
47 + [lints]
48 + workspace = true
@@ -27,3 +27,6 @@
27 27
28 28 [dev-dependencies]
29 29 tempfile = "3.25.0"
30 +
31 + [lints]
32 + workspace = true
@@ -14,3 +14,6 @@
14 14
15 15 [dev-dependencies]
16 16 tempfile = "3.25.0"
17 +
18 + [lints]
19 + workspace = true