Skip to main content

max / audiofiles

Take the mute-row allowance out of the tag queue's test quasi-immediate's `node::row` now registers widget info for the strip it claims, so a pressable row is in the accessibility tree instead of absent, and the queue's fidelity test no longer has to grant that its tag groups are unreachable by anything but a mouse.
Co-Authored-By
Claude Opus 5 (1M context) <noreply@anthropic.com>
Author: Max Johnson <me@maxj.phd> · 2026-08-22 17:45 UTC
Signed with PGP, not checked
Commit: 44f64ab25f55ee4db54157eb5a8439e8316eeaa4
Parent: a0d2492
1 file changed, +1 insertion, -17 deletions
@@ -563,20 +563,6 @@
563 563 self.gaining(label)
564 564 }
565 565
566 - /// A row the description makes pressable and `quasi-immediate` draws mute.
567 - ///
568 - /// `node::row` claims the strip with a bare `ui.interact`, which registers
569 - /// no `WidgetInfo`, so no node reaches the widget tree at all. The press
570 - /// works under a mouse and does not exist for anything else: a keyboard or
571 - /// screen-reader user cannot open a row.
572 - ///
573 - /// Worse than the two label findings beside it, which mis-name a control
574 - /// that is at least there. Filed against quasicoherent.
575 - #[must_use]
576 - pub(super) fn mute_row(self, label: &str) -> Self {
577 - self.gaining(label)
578 - }
579 -
580 566 /// Assert the two sides offer the same thing, panicking with a diff if not.
581 567 pub(super) fn assert(&self, described: &Offering, shipped: &Offering) {
582 568 let mut want: BTreeMap<Offer, isize> = BTreeMap::new();
@@ -936,7 +922,5 @@
936 922 // No `in_a_window`: the queue is a full-screen mode drawn into the app's own
937 923 // pane, which is what the shipped screen was, so there is no frame around it
938 924 // to discount.
939 - Parity::strict()
940 - .mute_row("instrument.drum.kick")
941 - .assert(&described, &drawn);
925 + Parity::strict().assert(&described, &drawn);
942 926 }