settings: say the System tab is built, and drop its dead-code allow
The System tab was finished and its module doc still described it as
unbuilt: "the next step of the build order; it says so on screen rather
than rendering an empty pane". render_system draws the same form over
SystemBind, which is the two-binds-one-engine seam working as designed.
The screen was right and the comment above it was describing an older
one.
system.rs carried #![allow(dead_code)] from when SystemBind existed but
nothing constructed it. Everything in it is reachable now, so the allow
was only suppressing a check that has nothing to report. Verified on a
forced rebuild rather than a cached one.
What the tab genuinely still does is speak up when no timedatectl
answers, and the doc now says that is the empty state rather than the
whole tab.
- Co-Authored-By
- Claude Opus 5 (1M context) <noreply@anthropic.com>
2 files changed,
+10 insertions,
-6 deletions
| 6 |
6 |
|
//! app each one configures rather than presented as paths. What differs between
|
| 7 |
7 |
|
//! them is only the [`Bind`](crate::bind::Bind) under the form.
|
| 8 |
8 |
|
//!
|
| 9 |
|
- |
//! This module carries the tab chrome and the Applications tab. The System tab
|
| 10 |
|
- |
//! is the next step of the build order; it says so on screen rather than
|
| 11 |
|
- |
//! rendering an empty pane, because a tab that looks finished and does nothing
|
| 12 |
|
- |
//! is worse than one that says what it is waiting for.
|
|
9 |
+ |
//! This module carries the tab chrome and both tabs. The System tab renders
|
|
10 |
+ |
//! the same form over [`SystemBind`](crate::system::SystemBind), which is the
|
|
11 |
+ |
//! seam working as intended: one form engine, two binds, and nothing in the
|
|
12 |
+ |
//! rendering path that knows which it is drawing.
|
|
13 |
+ |
//!
|
|
14 |
+ |
//! Where the System tab still says something rather than showing a form is
|
|
15 |
+ |
//! when nothing answers: no `timedatectl` means no live state, and the pane
|
|
16 |
+ |
//! says that instead of going blank. A development box in a container is not
|
|
17 |
+ |
//! an Alloy install, and that is the honest thing to tell someone looking at
|
|
18 |
+ |
//! one.
|
| 13 |
19 |
|
//!
|
| 14 |
20 |
|
//! ## What a schema catalog is
|
| 15 |
21 |
|
//!
|
| 57 |
57 |
|
//!
|
| 58 |
58 |
|
//! <!-- wiki: alloy-settings -->
|
| 59 |
59 |
|
|
| 60 |
|
- |
#![allow(dead_code)]
|
| 61 |
|
- |
|
| 62 |
60 |
|
use anyhow::Result;
|
| 63 |
61 |
|
use toml::Value;
|
| 64 |
62 |
|
|